Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): get backend nvme controller/path cmds #440

Merged

Conversation

artek-koltun
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 101 lines in your changes are missing coverage. Please review.

Comparison is base (3e3e7eb) 18.61% compared to head (f3703c3) 19.03%.

Files Patch % Lines
cmd/storage/backend/nvme_controller.go 0.00% 30 Missing ⚠️
cmd/storage/backend/nvme_path.go 0.00% 30 Missing ⚠️
cmd/storage/backend/backend.go 0.00% 27 Missing ⚠️
cmd/storage/storage.go 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
+ Coverage   18.61%   19.03%   +0.42%     
==========================================
  Files          62       62              
  Lines       10383    10510     +127     
==========================================
+ Hits         1933     2001      +68     
- Misses       8191     8238      +47     
- Partials      259      271      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artek-koltun artek-koltun force-pushed the feat-get-backend-nvme-controller-cmd branch 2 times, most recently from 52be64b to 1e82a9f Compare February 9, 2024 14:11
@artek-koltun artek-koltun marked this pull request as ready for review February 12, 2024 07:43
@artek-koltun artek-koltun requested a review from a team as a code owner February 12, 2024 07:43
@artek-koltun artek-koltun marked this pull request as draft February 12, 2024 07:43
Copy link
Contributor

@sandersms sandersms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@artek-koltun artek-koltun force-pushed the feat-get-backend-nvme-controller-cmd branch from 1e82a9f to f2dc44f Compare February 14, 2024 07:26
@artek-koltun artek-koltun marked this pull request as ready for review February 14, 2024 07:26
@artek-koltun artek-koltun force-pushed the feat-get-backend-nvme-controller-cmd branch 4 times, most recently from 76a385d to f3703c3 Compare February 14, 2024 07:58
@artek-koltun artek-koltun merged commit 14d8df1 into opiproject:main Feb 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants