Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(evpn): issue259 consider breaking too long files #265

Merged
merged 1 commit into from
Aug 10, 2023
Merged

fix(evpn): issue259 consider breaking too long files #265

merged 1 commit into from
Aug 10, 2023

Conversation

atulpatel261194
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 10, 2023 •
edited
Loading

Codecov Report

Merging #265 (2024719) into main (8b970c0) will decrease coverage by 1.88%.
Report is 7 commits behind head on main.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #265      +/-   ##
========================================
- Coverage   9.86%   7.98%   -1.88%     
========================================
  Files          8      13       +5     
  Lines       1643    2028     +385     
========================================
  Hits         162     162              
- Misses      1463    1848     +385     
  Partials      18      18
Files Changed Coverage Δ
network/bridge_port.go 0.00% <0.00%> (ø)
network/evpn.go 0.00% <0.00%> (ø)
network/logical_bridge.go 0.00% <0.00%> (ø)
network/svi.go 0.00% <0.00%> (ø)
network/utils.go 0.00% <0.00%> (ø)
network/vrf.go 0.00% <0.00%> (ø)
storage/frontend.go 0.00% <0.00%> (ø)

@glimchb glimchb linked an issue Aug 10, 2023 that may be closed by this pull request
evpn: consider breaking too long files #259
Closed
glimchb
glimchb requested changes Aug 10, 2023
View reviewed changes
Copy link
Member

@glimchb glimchb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • in cmd folder, file names like evpn-svi.go or evpn-bridge-port.go is better ion my opinion
  • in network folder -test should be _test with underscore...

glimchb
glimchb approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@glimchb glimchb marked this pull request as ready for review August 10, 2023 17:26
@glimchb glimchb requested a review from a team as a code owner August 10, 2023 17:26
@glimchb glimchb merged commit a94c5e2 into opiproject:main Aug 10, 2023
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glimchb glimchb glimchb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

evpn: consider breaking too long files
2 participants
@atulpatel261194 @glimchb