-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add doc about kube-rbac-proxy #3448
Comments
+1 improve this doc upstream and link to it |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
/lifecycle frozen |
Maybe kube-rbac-proxy usage should be removed? Ref: kubernetes-sigs/kubebuilder#3907 (by @camilamacedo86 😉 ) |
Hi @sathieu The usage of kube-rbac-proxy is no longer supported. But you can see: kubernetes-sigs/kubebuilder#3907 Also, you can check that in the default scaffold of Kubebuilder we are using a func of Controller-Runtime to protect the metrics by default, see: https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v4/cmd/main.go#L116-L122 So, I think this issue is outdated and yes, the kube-rbac-proxy usage should be removed |
Feature Request
Is your feature request related to a problem? Please describe.
The new layout uses the https://github.com/brancz/kube-rbac-proxy to protect the project. SDK has not a doc that explains, what/when/why/how regards it.
Describe the solution you'd like
We need to add a section to better doc it and we might need first improve the docs in the upstream to just link it in our own.
The only kb doc that quotes it is : https://book.kubebuilder.io/reference/metrics.html
The text was updated successfully, but these errors were encountered: