Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add doc about kube-rbac-proxy #3448

Open
camilamacedo86 opened this issue Jul 16, 2020 · 7 comments
Open

Docs: Add doc about kube-rbac-proxy #3448

camilamacedo86 opened this issue Jul 16, 2020 · 7 comments
Labels
kind/documentation Categorizes issue or PR as related to documentation. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone

Comments

@camilamacedo86
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe.
The new layout uses the https://github.com/brancz/kube-rbac-proxy to protect the project. SDK has not a doc that explains, what/when/why/how regards it.

Describe the solution you'd like
We need to add a section to better doc it and we might need first improve the docs in the upstream to just link it in our own.
The only kb doc that quotes it is : https://book.kubebuilder.io/reference/metrics.html

@camilamacedo86 camilamacedo86 changed the title Docs: Docs: Add doc about kube-rbac-proxy Jul 16, 2020
@camilamacedo86 camilamacedo86 added the kind/documentation Categorizes issue or PR as related to documentation. label Jul 16, 2020
@camilamacedo86 camilamacedo86 added this to the Backlog milestone Jul 16, 2020
@asmacdo
Copy link
Member

asmacdo commented Jul 28, 2020

+1 improve this doc upstream and link to it

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 31, 2020
@camilamacedo86
Copy link
Contributor Author

/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 31, 2020
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 29, 2021
@camilamacedo86
Copy link
Contributor Author

/lifecycle frozen

@openshift-ci-robot openshift-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 29, 2021
@sathieu
Copy link

sathieu commented Sep 19, 2024

Maybe kube-rbac-proxy usage should be removed?

Ref: kubernetes-sigs/kubebuilder#3907 (by @camilamacedo86 😉 )

@camilamacedo86
Copy link
Contributor Author

Hi @sathieu

The usage of kube-rbac-proxy is no longer supported.
SDK need to update the Kubebuilder version as dependency to get the latest changes.

But you can see: kubernetes-sigs/kubebuilder#3907

Also, you can check that in the default scaffold of Kubebuilder we are using a func of Controller-Runtime to protect the metrics by default, see: https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v4/cmd/main.go#L116-L122

So, I think this issue is outdated and yes, the kube-rbac-proxy usage should be removed
It will happens when SDK bump the latest kubebuilder release and get the latest changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

5 participants