-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add labels to resources of CSV #2434
add labels to resources of CSV #2434
Conversation
Hi @akihikokuroda. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: akihikokuroda <[email protected]>
06d937a
to
525ecbb
Compare
@akihikokuroda: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@akihikokuroda could you please address the conflict? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akihikokuroda The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
closing PR as stale. Please re-open if it's still important. |
Description of the change:
This PR adds the labels in the deployment section of the CSV to the resources related to the deployment.
Motivation for the change:
This is a part of #2161 change. There are some other resources that are related to the permission or clusterPermission sections and the resources that related to the CSV itself. To add the labels to these resources, the Label(s) property must be added to each section of the CSV API definition.
Reviewer Checklist
/doc