mark unsafe the non-spec obj parameter #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelgatelement
force-pushed
the
gaelg/mark-unsafe-non-spec-object-upstream
branch
from
46cbea4
to
23a40e8
Compare
|
Hello, Can I get a review on this change ? What can I do to help getting this merged ? Thanks |
acornett21
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two magic variables in ansible-operator, one for the
_specand containing the whole object. If we have some jinja syntax in the annotations or in the status,markUnsafecurrently misses it and it fails when injecting the variable in the playbook/role.