Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): Externalize the plugins package #3

Merged

Conversation

everettraven
Copy link
Collaborator

@everettraven everettraven commented Jul 26, 2023

Description of the change:

  • Externalized the plugins package so that the plugin can be used as a phase 1.5 (external library) plugin by the Operator-SDK. This only externalizes the plugins package and does a bit of clean up. The testdata is still currently generated by using the baked in Operator-SDK binary but this test data generation logic is likely best updated in a follow up PR. For now I have a WIP PR up in the Operator-SDK repo showing the importing and use of this package.

This is an incremental step towards getting this to be a phase 2 plugin while allowing the Operator SDK to take incremental steps toward using an external ansible operator plugin.

Motivation for the change:

  • Adhere to the phase 1.5 plugin criteria that would allow the Operator SDK to eventually have a dependency on this repository and import the plugin for use within the Operator SDK binary.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@everettraven everettraven merged commit ab43854 into operator-framework:main Jul 31, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants