Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-proto-xfrm: update description for now-optional tunlink parameter #7248

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

divinehawk
Copy link
Contributor

@systemcrash
Copy link
Contributor

Can you handle the equivalent i18n strings also?

Does the field accept an empty value today?

@divinehawk
Copy link
Contributor Author

Can you handle the equivalent i18n strings also?

For the i18n, I believe I did that correctly.

Does the field accept an empty value today?

Yes, "unspecified" is permitted in the dropdown.

@systemcrash
Copy link
Contributor

Good. The i18n needs just the changes of the modified string (should be only 1-2 lines). You can exclude other updates eg pbr.

@feckert
Copy link
Member

feckert commented Sep 2, 2024

Can you please rebase!

@systemcrash
Copy link
Contributor

ping @divinehawk

@systemcrash
Copy link
Contributor

@divinehawk - please do not use merge branches - just rebase your changes against master

@divinehawk divinehawk marked this pull request as draft September 4, 2024 18:20
@divinehawk
Copy link
Contributor Author

@divinehawk - please do not use merge branches - just rebase your changes against master

Should be good now I think. Apologies for that.

@systemcrash systemcrash merged commit 01de201 into openwrt:master Sep 4, 2024
5 checks passed
@systemcrash
Copy link
Contributor

Thanks @divinehawk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants