Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-app-udpxy: fix luci-app-udpxy #7220

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

findlayfeng
Copy link
Contributor

@findlayfeng findlayfeng commented Jul 31, 2024

  • This PR is not from my main or master branch 💩, but a separate branch ✅
  • Each commit has a valid ✒️ Signed-off-by: <[email protected]> row (via git commit --signoff)
  • Each commit and PR title has a valid 📝 <package name>: title first line subject for packages
  • Incremented 🆙 any PKG_VERSION in the Makefile
  • Tested on: (architecture, openwrt version, browser) ✅
  • ( Preferred ) Mention: @1715173329
  • ( Preferred ) Screenshot or mp4 of changes:
  • ( Optional ) Closes: e.g. openwrt/luci#issue-number
  • ( Optional ) Depends on: e.g. udpxy: add option source_network packages#24702 in sister repo
  • Description: (describe the changes proposed in this PR)

modified bind and source option class to automatically generate possible values
Changed ipaddr in datatype to ip4addr, udpxy only supports ipv4
add option source_network

Signed-off-by: Feng Cheng <[email protected]>
@findlayfeng findlayfeng changed the title luci-app-udpxy: add option source_network luci-app-udpxy: fix luci-app-udpxy Jul 31, 2024
@systemcrash
Copy link
Contributor

@1715173329 is this OK for you?

@1715173329
Copy link
Member

@1715173329 is this OK for you?

I'm not the maintainer of this package nor an expert on luci, so it's up to you ;)

@systemcrash systemcrash merged commit 03ec6a8 into openwrt:master Sep 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants