configuration option to allow students to work on sets that are missi… #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgrice1
reviewed
Oct 1, 2024
| @@ -191,12 +191,14 @@ sub getSetStatus ($c, $set) { | |||
| $link_is_active = 0 unless $canViewUnopened; | |||
| push(@$other_messages, $c->restricted_progression_msg(0, $set->restricted_status * 100, @restricted)); | |||
| } elsif (!$canViewUnopened | |||
| && ($ce->{LTIVersion} ne '1p3' || !$ce->{LTI}{v1p3}{ignoreMissingSourcedID}) | |||
There was a problem hiding this comment.
This should be
Suggested change
| && ($ce->{LTIVersion} ne '1p3' || !$ce->{LTI}{v1p3}{ignoreMissingSourcedID}) | |
| && ($ce->{LTIVersion} ne 'v1p3' || !$ce->{LTI}{v1p3}{ignoreMissingSourcedID}) |
dlglin
changed the title
…ng the set sourced ID even in homework grade passback mode
Alex-Jordan
force-pushed
the
allowAccessWithNoSourcedID
branch
from
5685869
to
6dba68b
Compare
somiaj
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ng the set sourced ID even in homework grade passback mode
This is what I proposed in #2582.
I'm open to changing the name of the config variable. Also since it only makes sense to do this with LTI 1.3, I put it in
authem_LTI_1_3.confbut maybe that is not the best place.