Fix rendering static images when checking answers in the PG problem editor (hotfix of #2574) #2580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somiaj
approved these changes
Sep 24, 2024
drgrice1
force-pushed
the
render-problem-non-empty-filenames-hotfix
branch
from
191bdfc
to
be754e0
Compare
…ditor. This fixes issue openwebwork#2556 essentially as @somiaj suggests (although there is no need to first check that `$rh->{fileName}` is defined). The reason that `$rh->{fileName}` is defined is because the `default.html.ep` template always adds the `fileName` hidden field even when the `fileName` parameter is not defined in the original request. So if you click "Check Answers" it will be defined in `RenderProblem.pm` on that request.
drgrice1
force-pushed
the
render-problem-non-empty-filenames-hotfix
branch
from
be754e0
to
59ea248
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #2556 essentially as @somiaj suggests (although there is no need to first check that
$rh->{fileName}is defined).The reason that
$rh->{fileName}is defined is because thedefault.html.eptemplate always adds thefileNamehidden field even when thefileNameparameter is not defined in the original request. So if you click "Check Answers" it will be defined inRenderProblem.pmon that request.