Skip to content
This repository has been archived by the owner on Dec 20, 2023. It is now read-only.

WDM: Re-think the way subscription handlers are reclaimed #435

Open
jaylogue opened this issue Dec 4, 2019 · 0 comments
Open

WDM: Re-think the way subscription handlers are reclaimed #435

jaylogue opened this issue Dec 4, 2019 · 0 comments
Assignees

Comments

@jaylogue
Copy link
Contributor

jaylogue commented Dec 4, 2019

The current AbortSubscription method in SubscriptionHandler does one too many things - it aborts the subscription and reset the state of the handler if the refcount is one value (1) and releases the handler back to the pool if it's another (0).

This overloading is confusing, error-prone and causes un-necessary stack winding - calling AbortSubscription to abort a subscription results in aborting the subscription (1), then calling Release which calls AbortSubscription again, this time to handle (2).

This should be re-factored to separate out aborting a subscription, and releasing the handler object back to the pool.

This issue corresponds to WEAV-2367.

@jaylogue jaylogue self-assigned this Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant