Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Examples / Implementations for key request #177

Open
cre8 opened this issue Mar 14, 2024 · 4 comments
Open

feat: Examples / Implementations for key request #177

cre8 opened this issue Mar 14, 2024 · 4 comments
Assignees

Comments

@cre8
Copy link
Contributor

cre8 commented Mar 14, 2024

Section 3.5 lists 3 options to receive the key of an issuer:

  • JWT VC Issuer Metadata
  • X.509 Certificates
  • DID Document resolution

Right now the library defines "bring your own crypto". Meaning the the user has to implement the getVerifier(publicKeyJWK: object): Promise<(data: string, signatureBase64url: string) => Promise<boolean>>; by himself. The data field includes the encoded header and payload field, therefore all three options can be implemented.

@lukasjhan do you think it makes sense? We can not implement to resolve all did elements, but we could give some examples for this.

@lukasjhan
Copy link
Member

Yeah we could give them examples or implementations.

We already provide implementation for crypto. An example is the ES256 algorithm available in nodejs and broswer. And also we plan to support React Native env.

I think it's better to provide simple implemenation in our package.

@lukasjhan
Copy link
Member

lukasjhan commented Mar 16, 2024

I think we can make them by platform(nodejs, web etc.) or we can make pass the signer or verifier as a param.
Which way do you prefer? @cre8

@cre8
Copy link
Contributor Author

cre8 commented Mar 16, 2024

maybe it's enough to mention it in a readme, since the demanded implementation can be different: some are fine with the universal resolver, others want to resolve it locally. So we tell them how to implement it to give some hints.

@lukasjhan
Copy link
Member

maybe it's enough to mention it in a readme, since the demanded implementation can be different: some are fine with the universal resolver, others want to resolve it locally. So we tell them how to implement it to give some hints.

Okay I'll write a brief explanation on docs. Then Let's talk about more with the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants