-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change 'add wallet' form #37
Comments
I have some concerns with topics like "uses blockchain": I think we can get filter information like "which wallets are using blockchain". To do it we analyse the key managements referenced in the background and filter them. This will reduce the risk of inconsistency. E.g. A wallet supports the "anoncrdes with did:indy" profile I would like to go the "knowledge graph" instead of trying to stick with the old approach and just putting in the new stuff. It could increase the complexity a bit, but helps a lot with data consistency. |
If I understand correctly, you want to remove the direct input 'uses blockchain', but generate the answer to it based on the identifier method. In that case, I'd want to add that blockchain can be used for more purposes than just these two, namely also schema and credential definitions. I'm not sure if the case exists where wallets uses blockchain for schema/credential definitions, but not for public identifiers. But in that case, your approach would miss it. |
There is no profile I am aware of with your described scenario. The schema part is covered by the credential format resource (JWT-VC, MDOC, etc). There we only added "rich schemas/semantic", but we are not defining how the schema is provided. From a requirement point of view I don't see "use blockchain" as a good filter, because the value says nothing about "how is blockchain used". Is it used with a real benefit or just to get the checkmark? For the user it has also no impact since it is all handled by the wallet/agent in the background. This analysis looks more for a white paper with the subject "how are ssi wallets using blockchain" |
There are some organizations who just want to avoid all technology related to blockchains. Whether that's a reasonable approach or not could be discussed somewhere else, but I kind of understand the need to separate "blockchain-based wallets" and "non-blockchain wallets". Of course, "use blockchain" doesn't work even for this filtering, since there are wallets that optionally can use blockchain. I think that whether a wallet uses (or can use) blockchains can often be deducted from the supported DID methods or credential profiles. I'm in favor of removing "uses blockchain" and adding some filtering logic based on other characteristics later. |
wallets-add.component.ts has a form component The form component (.ts file) also has a property |
@samuelmr I think I missed some values when generating it, I will handle it in a separate issue and PR. We should add this topic on the next call for better discussion |
This should be renamed to 'Add digital wallet or agent'.
The form should include the following fields:
This should then be parsed to have the following format
@cre8 is this workable?
The text was updated successfully, but these errors were encountered: