Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query for the support of Ed25519Signature2020 in DID Creation #2082

Open
Sshovon opened this issue Nov 5, 2024 · 3 comments
Open

Query for the support of Ed25519Signature2020 in DID Creation #2082

Sshovon opened this issue Nov 5, 2024 · 3 comments

Comments

@Sshovon
Copy link
Contributor

Sshovon commented Nov 5, 2024

During did:key creation, we currently have the option to specify the KeyType, which by default uses Ed25519Signature2018 signature suite during did document generation. Although Ed25519Signature2020 has been added as a signature suite in the latest stable release (0.5.12) of Credo, there doesn’t appear to be an option to create a DID using that. Could anyone confirm if this understanding is correct, or if there are any available options to achieve this?

Also if we have the did:key with Ed25519Signature2018, can we use that DID to issue a credential with proofType Ed25519VerificationKey2020 ?

@Sshovon Sshovon changed the title Query for the support of Ed25519VerificationKey2020 in DID Creation Query for the support of Ed25519Signature2020 in DID Creation Nov 5, 2024
@TimoGlastra
Copy link
Contributor

So for did:key it doesn't really matter as only the key is encoded in the did, not the whole verification method.

I think once we switch to 0.6 we should change the default resolved key to Ed25519VerificationKey2020 (or even better MultiKey/JsonWebKey).

However i think you should be able to use any verification method we support and which we can extract the right key instance from for issuance. So if you want to sign using EdDSA, we support Ed25519VerificationKey2018, Ed25519VerificatiomKey2020, JsonWebKey, and MultiKey. If not, there is some code still that doesn't use the correct transformation logic -- mainly for JSON-LD suites which we should fix

@Sshovon
Copy link
Contributor Author

Sshovon commented Nov 5, 2024

Yes, JSON-LD issuance doesn't work properly using Ed25519VerificationKey2020. Looking forward to the 0.6 release. Thanks for the quick reply. Really appreciated.

@Sshovon Sshovon closed this as completed Nov 5, 2024
@TimoGlastra
Copy link
Contributor

Let's keep this open to track the status

@TimoGlastra TimoGlastra reopened this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants