PR Checklists #914
Replies: 4 comments 1 reply
-
Good idea! |
Beta Was this translation helpful? Give feedback.
-
Sounds good! I think even the checklist without the enforcement would be helpful, but interested to see how the action will help. In addition we should probably also create an issue template with the new action forms for bug reports and feature requests. This will push both contributors and users of the framework to submit better issues. Is this something you'll be willing to open a PR for? |
Beta Was this translation helpful? Give feedback.
-
I found this template yesterday which looks pretty good: https://github.com/vitejs/vite/blob/main/.github/ISSUE_TEMPLATE/bug_report.yml. They also have an envinfo command that automatically get's all required system info:
Will output:
|
Beta Was this translation helpful? Give feedback.
-
Getting even further from the initial topic discussion (but also usign it for the issue template part) I created this reproduction template that we can request for bugs / issues: https://github.com/TimoGlastra/afj-reproduction-template |
Beta Was this translation helpful? Give feedback.
-
Hi all!
With the introduction of the Aries JavaScript Docs and also because I frequently forget to add tests, I'd like to suggest we create a PR template with some default checklist items that need to be ticked off before we merge.
I did a quick search and it looks like we can use this require checklist action to enforce all items are checked off before a merge is allowed to happen. It simply looks for checklist items in the PR body and blocks if any are unticked. Not sure if this is what we want, because this doesn't allow for optional checkboxes.
This list is definitely incomplete, but as a start:
As always, so suggestions are welcome!
Beta Was this translation helpful? Give feedback.
All reactions