Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this support OT 2.0 and scope managers? #18

Open
yurishkuro opened this issue Aug 20, 2018 · 6 comments
Open

Does this support OT 2.0 and scope managers? #18

yurishkuro opened this issue Aug 20, 2018 · 6 comments
Assignees

Comments

@yurishkuro
Copy link

cc @carlosalberto

@carlosalberto
Copy link
Contributor

It does not yet - I've been working on changes (+ additional cleanups) on v1.0.0 branches for Python instrumentation in contrib, and I'd expect to have them ready for Flask by the end of the week (already started it).

@yurishkuro
Copy link
Author

looking forward to it

@rmfitzpatrick
Copy link
Contributor

rmfitzpatrick commented Sep 10, 2018

@carlosalberto, does this require a FlaskScopeManager in https://github.com/opentracing/opentracing-python that uses _request_ctx_stack? I'd be happy to take a crack at that if so.

edit: Looking at the Tornado scope manager, it seemed like this was needed so I made an attempt: opentracing/opentracing-python#105

I'll be sure to open a PR with my tracer changes that source this if adopted in opentracing-python.

@yurishkuro
Copy link
Author

@carlosalberto does #23 resolve this one?

@Jamim
Copy link
Contributor

Jamim commented Dec 19, 2018

ping @carlosalberto

@analytically
Copy link

Can't seem to get this working with Flask-Opentracing 1.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants