Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback sushy-emulator to public net if no ctlplane #2365

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Fallback sushy-emulator to public net if no ctlplane #2365

merged 1 commit into from
Sep 23, 2024

Conversation

hjensas
Copy link
Contributor

@hjensas hjensas commented Sep 19, 2024

If ctlplane network is not enabled/attached to the controller-0 node fallback the sushy.utility host record to the public net.

This allows me to configure controller with only public net:

cifmw_libvirt_manager_configuration:
  vms:
    controller:
      nets:
        - ocpbm

cifmw_networking_definition:
  instances:
    controller-0:
      networks: {}

@github-actions github-actions bot marked this pull request as draft September 19, 2024 18:01
@github-actions GitHub Actions
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@hjensas
Fallback sushy-emulator to public net if no ctlplane
4639357 
If ctlplane network is not enabled/attached to the controller-0 node
fallback the sushy.utility host record to the public net.

This allows me to configure controller with only public net:

```
cifmw_libvirt_manager_configuration:
  vms:
    controller:
      nets:
        - ocpbm

cifmw_networking_definition:
  instances:
    controller-0:
      networks: {}
```
@hjensas hjensas force-pushed the sushy-emulator-fallback-public-net branch from 3c99fa1 to 4639357 Compare September 19, 2024 18:02
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/588608daee004310bfaf76a3513f1aa0

✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 41s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 34s
❌ build-push-container-cifmw-client TIMED_OUT in 1h 30m 31s
✔️ cifmw-molecule-reproducer SUCCESS in 18m 27s

@hjensas hjensas marked this pull request as ready for review September 20, 2024 08:31
@hjensas
Copy link
Contributor Author

hjensas commented Sep 20, 2024

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/fc98476f0efe44f995098ee07b99bde5

✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 33s
✔️ cifmw-pod-pre-commit SUCCESS in 6m 54s
❌ build-push-container-cifmw-client TIMED_OUT in 1h 30m 40s
✔️ cifmw-molecule-reproducer SUCCESS in 15m 34s

@hjensas
Copy link
Contributor Author

hjensas commented Sep 20, 2024

recheck

@pablintino
Copy link
Collaborator

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rebtoor
rebtoor approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@rebtoor rebtoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 23, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 5cb063d into openstack-k8s-operators:main Sep 23, 2024
5 checks passed
@hjensas hjensas deleted the sushy-emulator-fallback-public-net branch October 1, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebtoor rebtoor rebtoor approved these changes

Assignees

@rebtoor rebtoor

Labels
approved lgtm Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hjensas @pablintino @rebtoor