Correct shellcheck errors #2268
Conversation
Since we're moving to shellcheck instead of bashate, let's get it green. This patch fixes, but also disables some checks on specific lines. It also integrate a "bashate" related ignore since the check is still in place, we can remove it later.
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/496d375adf99445396076265c6087de2 ❌ openstack-k8s-operators-content-provider RETRY_LIMIT in 2m 39s |
| @@ -6,8 +6,9 @@ VENV_DIR="${DOCS_DIR}/_venv" | |||
| BUILD_TYPE="${BUILD_TYPE:=static}" | |||
|
|
|||
| # Create a virtual environment and activate it | |||
| python -m venv ${VENV_DIR} && source ${VENV_DIR}/bin/activate | |||
| pip3 install -r ${DOCS_DIR}/doc-requirements.txt | |||
| # shellcheck disable=SC1091 | |||
There was a problem hiding this comment.
SC1091 is annoying, imho we can safely add to ignore list.
Since we're moving to shellcheck instead of bashate, let's get it green.
This patch fixes, but also disables some checks on specific lines. It
also integrate a "bashate" related ignore since the check is still in
place, we can remove it later.