Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swift network for RGW to HCI scenario #404

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fultonj
Copy link
Contributor

@fultonj fultonj commented Sep 18, 2024

When Ceph RGW is used, an endpoint for Swift storage is hosted not in a pod on k8s but on an EDPM node. Thus, a service hosted on an EDPM node will need to be accessed by cloud users from a separate network.

This patch adds the Swift storage network (swift) with VLAN 25 and range 172.22.0.0/24 in the HCI values example. The Swift network is configured on the HCI EDPM nodes and an NNCP, NAD, L2Advertisement and IPAddressPool are defined so that a pod in k8s can connect to it; such as the tempest pod which will perform object storage tests.

Jira: https://issues.redhat.com/browse/OSPRH-6675
Depends-On: openstack-k8s-operators/ci-framework#2301

Copy link

openshift-ci bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fultonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this once @fultonj is satisfied with its testing results

name: swift
subnetName: subnet1
- op: add
path: /spec/nodes/edpm-compute-0/networks/-
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is failing because the name will always have a random string appended to it:

       nodes:
            edpm-compute-eeua7yef-0:
                ansible:
                    host: 192.168.122.100
                hostName: compute-eeua7yef-0
                networks:

I get this error:

add operation does not apply: doc is missing path: \\\"/spec/nodes/edpm-compute-0/networks/-\\\": missing value\""'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of the dependency on openstack-k8s-operators/ci-framework#2301 the ci-framework when the job is run by the ci-framework I already end up having those values. Thus, I could simply remove those lines.

        networks:
        -   defaultRoute: true
            name: ctlplane
            subnetName: subnet1
        -   name: internalapi
            subnetName: subnet1
        -   name: storage
            subnetName: subnet1
        -   name: tenant
            subnetName: subnet1
        nodes:
            edpm-compute-eeua7yef-0:
                ansible:
                    host: 192.168.122.100
                hostName: compute-eeua7yef-0
                networks:
                -   defaultRoute: true
                    fixedIP: 192.168.122.100
                    name: ctlplane
                    subnetName: subnet1
                -   name: internalapi
                    subnetName: subnet1
                -   name: storage
                    subnetName: subnet1
                -   name: storagemgmt
                    subnetName: subnet1
                -   name: swift
                    subnetName: subnet1
                -   name: tenant
                    subnetName: subnet1
            edpm-compute-eeua7yef-1:
                ansible:
                    host: 192.168.122.101
                hostName: compute-eeua7yef-1
                networks:
                -   defaultRoute: true
                    fixedIP: 192.168.122.101
                    name: ctlplane
                    subnetName: subnet1
                -   name: internalapi
                    subnetName: subnet1
                -   name: storage
                    subnetName: subnet1
                -   name: storagemgmt
                    subnetName: subnet1
                -   name: swift
                    subnetName: subnet1
                -   name: tenant
                    subnetName: subnet1
            edpm-compute-eeua7yef-2:
                ansible:
                    host: 192.168.122.102
                hostName: compute-eeua7yef-2
                networks:
                -   defaultRoute: true
                    fixedIP: 192.168.122.102
                    name: ctlplane
                    subnetName: subnet1
                -   name: internalapi
                    subnetName: subnet1
                -   name: storage
                    subnetName: subnet1
                -   name: storagemgmt
                    subnetName: subnet1
                -   name: swift
                    subnetName: subnet1
                -   name: tenant
                    subnetName: subnet1

When Ceph RGW is used, an endpoint for Swift storage is
hosted not in a pod on k8s but on an EDPM node. Thus, a
service hosted on an EDPM node will need to be accessed
by cloud users from a separate network.

This patch adds the Swift storage network (swift) with
VLAN 25 and range 172.22.0.0/24 in the HCI values example.
The Swift network is configured on the HCI EDPM nodes
and an NNCP, NAD, L2Advertisement and IPAddressPool are
defined so that a pod in k8s can connect to it; such as
the tempest pod which will perform object storage tests.

Jira: https://issues.redhat.com/browse/OSPRH-6675
Depends-On: openstack-k8s-operators/ci-framework#2301

Signed-off-by: John Fulton <[email protected]>
Copy link

openshift-ci bot commented Sep 20, 2024

@fultonj: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 50abb86 link true /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants