Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'local' network type in the Control Plane CRs #388

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Add 'local' network type in the Control Plane CRs #388

merged 1 commit into from
Sep 5, 2024

Conversation

slawqo
Copy link
Contributor

@slawqo slawqo commented Sep 5, 2024

Lack of this 'local' network type breaks somehow some Horizon integration tests as this is first choice in the Horizon UI. From Neutron PoV there is no reason not to load this driver so lets enable that driver in the Neutron's config.

@slawqo
Add 'local' network type in the Control Plane CRs
82b8592 
Lack of this 'local' network type breaks somehow some Horizon
integration tests as this is first choice in the Horizon UI.
From Neutron PoV there is no reason not to load this driver so lets
enable that driver in the Neutron's config.
@karelyatin
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 5, 2024
fultonj
fultonj approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@fultonj fultonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fultonj, slawqo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 5, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d0e6a4b9342c401f9e9d16560474c075

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-uni01alpha SUCCESS in 3m 50s
✔️ rhoso-architecture-validate-uni04delta SUCCESS in 3m 53s
✔️ rhoso-architecture-validate-uni04delta-ipv6 SUCCESS in 4m 00s
✔️ rhoso-architecture-validate-uni06zeta SUCCESS in 3m 38s
✔️ rhoso-architecture-validate-uni07eta SUCCESS in 4m 02s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 2de98f5 into openstack-k8s-operators:main Sep 5, 2024
7 checks passed
@fultonj fultonj added the needs-18.0.0-proposed-cherry-pick Owner should cherry pick this PR to 18.0.0-proposed after it merges label Sep 5, 2024
@fultonj
Copy link
Contributor

fultonj commented Sep 5, 2024

@slawqo since downstream ci uses 18.0.0-proposed, if you want this tested downstream please cherry pick as per:

https://github.com/openstack-k8s-operators/architecture/blob/main/docs/contributing/cherry-picking.md

@slawqo
Copy link
Contributor Author

slawqo commented Sep 5, 2024

thx @fultonj I just proposed backport #389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fultonj fultonj fultonj approved these changes

@cjeanner cjeanner Awaiting requested review from cjeanner

Assignees

@fultonj fultonj

@karelyatin karelyatin

Labels
approved lgtm needs-18.0.0-proposed-cherry-pick Owner should cherry pick this PR to 18.0.0-proposed after it merges
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slawqo @karelyatin @fultonj