[OSPRH-6547] Split lib/dataplane into nodeset and deployment #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abays
force-pushed
the
split_lib_dataplane
branch
from
ba2de27
to
a3ff389
Compare
abays
force-pushed
the
split_lib_dataplane
branch
from
a3ff389
to
2b89719
Compare
abays
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits the
lib/dataplaneinto sub-dirs for theOpenStackDataPlaneNodeSetand theOpenStackDataPlaneDeployment, so that they may be atomically utilizied. Should hopefully preserve backwards compatibility for existing VAs and DTs that want to render both by still using the baselib/dataplanedir. I tested VA1 rendering with the existing logic and diffed it against the data plane templates generated by the new structure, and they were equal.