uni06zeta initial version #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afazekas
force-pushed
the
zeta
branch
6 times, most recently
from
1a5e5f2
to
a342334
Compare
afazekas
force-pushed
the
zeta
branch
3 times, most recently
from
c0d93f1
to
46b8b56
Compare
cjeanner
reviewed
Apr 15, 2024
abays
reviewed
Apr 15, 2024
sdatko
added a commit
to sdatko/openstack-k8s-operators-architecture
that referenced
this pull request
Apr 15, 2024
Based-On: openstack-k8s-operators#83 Based-On: openstack-k8s-operators#145 Based-On: openstack-k8s-operators#152 Based-On: openstack-k8s-operators#159 Jira: https://issues.redhat.com/browse/OSPRH-4989
sdatko
added a commit
to sdatko/openstack-k8s-operators-architecture
that referenced
this pull request
Apr 15, 2024
Based-On: openstack-k8s-operators#83 Based-On: openstack-k8s-operators#145 Based-On: openstack-k8s-operators#152 Based-On: openstack-k8s-operators#159 Jira: https://issues.redhat.com/browse/OSPRH-4989
sdatko
added a commit
to sdatko/openstack-k8s-operators-architecture
that referenced
this pull request
Apr 17, 2024
Based-On: openstack-k8s-operators#83 Based-On: openstack-k8s-operators#145 Based-On: openstack-k8s-operators#152 Based-On: openstack-k8s-operators#159 Jira: https://issues.redhat.com/browse/OSPRH-4989
sdatko
added a commit
to sdatko/openstack-k8s-operators-architecture
that referenced
this pull request
Apr 17, 2024
Based-On: openstack-k8s-operators#83 Based-On: openstack-k8s-operators#145 Based-On: openstack-k8s-operators#152 Based-On: openstack-k8s-operators#159 Jira: https://issues.redhat.com/browse/OSPRH-4989
afazekas
force-pushed
the
zeta
branch
7 times, most recently
from
c4abfe7
to
36db2eb
Compare
abays
reviewed
Apr 18, 2024
leifmadsen
reviewed
Apr 18, 2024
abays
reviewed
Apr 18, 2024
|
I removing the hook candidates they never meant to be the final version, |
fultonj
reviewed
Apr 18, 2024
This was referenced Apr 18, 2024
afazekas
force-pushed
the
zeta
branch
3 times, most recently
from
2b7dd18
to
9209cb1
Compare
abays
reviewed
Apr 19, 2024
| cd architecture/examples/dt/uni06zeta | ||
| ``` | ||
|
|
||
| Edit [controle-plane/service-values.yaml](control-plane/service-values.yaml) and |
There was a problem hiding this comment.
Suggested change
| Edit [controle-plane/service-values.yaml](control-plane/service-values.yaml) and | |
| Edit [control-plane/service-values.yaml](control-plane/service-values.yaml) and |
abays
reviewed
Apr 19, 2024
| ``` | ||
|
|
||
| Edit [controle-plane/service-values.yaml](control-plane/service-values.yaml) and | ||
| [nncp/values.yaml](nncp/values.yaml). |
There was a problem hiding this comment.
Suggested change
| [nncp/values.yaml](nncp/values.yaml). | |
| [control-plane/nncp/values.yaml](control-plane/nncp/values.yaml). |
This is based on other peding changes referenced below. Line-length warning limit extended some config lines are really long, and less readable when wrapped. https://github.com/openstack-k8s-operators/architecture/pull/73/files#diff-2b848ad66a53ba3c4f0a6111d518dcf85c4995f7299ee657c76c1a95a0058ebe 184193a #83
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uni06zeta initial version
This is based on other peding changes referenced below.
It can produce a passing minimal CI job ATM.
Line-length warning limit extended some config lines are really long,
and less readable when wrapped.
Depends-On: #188
https://github.com/openstack-k8s-operators/architecture/pull/73/files#diff-2b848ad66a53ba3c4f0a6111d518dcf85c4995f7299ee657c76c1a95a0058ebe
184193a
#83