-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure the OCP-CI to build and push VSCode notebook [RHOAI] #45089
Configure the OCP-CI to build and push VSCode notebook [RHOAI] #45089
Conversation
c927ec9
to
fe6798e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
just one commendt
...or/config/red-hat-data-services/notebooks/red-hat-data-services-notebooks-release-2023a.yaml
Outdated
Show resolved
Hide resolved
fe6798e
to
47d30dc
Compare
/hold |
47d30dc
to
b54cb73
Compare
b54cb73
to
66f67a3
Compare
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Right, I will rename the title to have two separated PRs for each notebook. The plan was to use CentOS in ODH and UBI or RHEL for RHOAI. |
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atheo89, harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/pj-rehearse ack |
@atheo89: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Configure the CI to build and push VSCode notebook into RHOAI.
Ref issue: opendatahub-io/notebooks#283