Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure the OCP-CI to build and push VSCode notebook [RHOAI] #45089

Merged

Conversation

atheo89
Copy link
Contributor

@atheo89 atheo89 commented Oct 31, 2023

Configure the CI to build and push VSCode notebook into RHOAI.

Ref issue: opendatahub-io/notebooks#283

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2023
@atheo89 atheo89 changed the title Configure the CI to build and push VSCode and RStudio into RHODS Configure the OCP-CI to build and push VSCode and RStudio into RHODS Oct 31, 2023
@atheo89 atheo89 changed the title Configure the OCP-CI to build and push VSCode and RStudio into RHODS Configure the OCP-CI to build and push VSCode and RStudio [RHODS] Oct 31, 2023
@atheo89 atheo89 changed the title Configure the OCP-CI to build and push VSCode and RStudio [RHODS] Configure the OCP-CI to build and push VSCode and RStudio notebooks [RHODS] Oct 31, 2023
@atheo89 atheo89 force-pushed the add-vscode-rstudio-downstream branch from c927ec9 to fe6798e Compare October 31, 2023 12:41
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
just one commendt

@atheo89 atheo89 force-pushed the add-vscode-rstudio-downstream branch from fe6798e to 47d30dc Compare November 2, 2023 10:37
@atheo89
Copy link
Contributor Author

atheo89 commented Nov 3, 2023

/hold
/wip

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2023
@atheo89 atheo89 force-pushed the add-vscode-rstudio-downstream branch from 47d30dc to b54cb73 Compare November 3, 2023 12:24
@atheo89 atheo89 force-pushed the add-vscode-rstudio-downstream branch from b54cb73 to 66f67a3 Compare November 3, 2023 12:28
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@atheo89: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-red-hat-data-services-notebooks-main-images red-hat-data-services/notebooks presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jstourac
Copy link
Contributor

jstourac commented Nov 3, 2023

Two points:

  • Title of the MR is talking about both R Studio and VS Code but I can se only VS Code changes included here - could you please complete?
  • In the notebook repository, we still build both images on top of the C9S (R Studio and VS Code) whether here we're going with the RHEL9 already.

@atheo89
Copy link
Contributor Author

atheo89 commented Nov 6, 2023

  • Title of the MR is talking about both R Studio and VS Code but I can se only VS Code changes included here - could you please complete?

Right, I will rename the title to have two separated PRs for each notebook.

  • In the notebook repository, we still build both images on top of the C9S (R Studio and VS Code) whether here we're going with the RHEL9 already.

The plan was to use CentOS in ODH and UBI or RHEL for RHOAI.

@atheo89 atheo89 changed the title Configure the OCP-CI to build and push VSCode and RStudio notebooks [RHODS] Configure the OCP-CI to build and push VSCode notebook [RHOAI] Nov 6, 2023
@atheo89
Copy link
Contributor Author

atheo89 commented Nov 6, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2023
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

👍

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2023
Copy link
Contributor

openshift-ci bot commented Nov 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89, harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89
Copy link
Contributor Author

atheo89 commented Nov 7, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 7, 2023
Copy link
Contributor

openshift-ci bot commented Nov 7, 2023

@atheo89: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b5e39b6 into openshift:master Nov 7, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants