Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore errors and warnings #67803

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 13, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 13, 2023

🤖 Wed Feb 14 14:21:24 - Prow CI generated the docs preview: https://67803--ocpdocs-pr.netlify.app

@RichardHoch RichardHoch marked this pull request as ready for review November 26, 2023 14:58
@RichardHoch RichardHoch changed the title WIP Restore errors and warnings Restore errors and warnings Nov 26, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2023
@RichardHoch
Copy link
Contributor Author

@kaovilai I made the changes you suggest.
@sseago I see that in the comments to openshift/oadp-operator#1222, you talked about adding another note in the future-- should I go ahead and create that note here, subject to your approval, of course?

@RichardHoch
Copy link
Contributor Author

RichardHoch commented Feb 11, 2024

@sseago @kaovilai Please review this PR.

@kalexand-rh
Copy link
Contributor

4.11 is now EOL, and we are no longer updating it. Please set the versions to 4.12+.

@RichardHoch
Copy link
Contributor Author

@stillalearner Please review this PR.

Copy link

@stillalearner stillalearner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RichardHoch
Copy link
Contributor Author

/label OADP
/label peer-review-needed

@openshift-ci openshift-ci bot added OADP Label for all OADP PRs peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 14, 2024
@agantony
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 14, 2024
Copy link
Contributor

@agantony agantony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions for your consideration; overall lgtm!
Also, please add the preview link in the PR desription.

modules/migration-debugging-velero-resources.adoc Outdated Show resolved Hide resolved
modules/migration-debugging-velero-resources.adoc Outdated Show resolved Hide resolved
modules/migration-debugging-velero-resources.adoc Outdated Show resolved Hide resolved
@agantony
Copy link
Contributor

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added the peer-review-done Signifies that the peer review team has reviewed this PR label Feb 14, 2024
@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 14, 2024
@RichardHoch
Copy link
Contributor Author

If merge review looks good, please merge immediately. Thanks!

@JoeAldinger JoeAldinger added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 14, 2024
@JoeAldinger JoeAldinger added this to the Continuous Release milestone Feb 14, 2024
Copy link
Contributor

@JoeAldinger JoeAldinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick question

modules/migration-debugging-velero-resources.adoc Outdated Show resolved Hide resolved
@RichardHoch
Copy link
Contributor Author

@JoeAldinger: Fixed it. Good catch!

@JoeAldinger
Copy link
Contributor

I'll merge as soon as it builds @RichardHoch

Copy link

openshift-ci bot commented Feb 14, 2024

@RichardHoch: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoeAldinger JoeAldinger merged commit c964b57 into openshift:main Feb 14, 2024
2 checks passed
@JoeAldinger
Copy link
Contributor

/cherrypick enterprise-4.15

@JoeAldinger
Copy link
Contributor

/cherrypick enterprise-4.14

@JoeAldinger
Copy link
Contributor

/cherrypick enterprise-4.13

@JoeAldinger
Copy link
Contributor

/cherrypick enterprise-4.12

@openshift-cherrypick-robot

@JoeAldinger: new pull request created: #71612

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JoeAldinger: new pull request created: #71613

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JoeAldinger: new pull request created: #71614

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JoeAldinger: new pull request created: #71615

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


* If there are `Velero` errors, but no resource-specific errors, in the output of a `describe` command, it is possible that the restore completed without any actual problems in restoring workloads, but carefully validate post-restore applications.
+
For example, if the output contains `PodVolumeRestore` or node sgent-related errors, check the status of `PodVolumeRestores` and `DataDownloads`. If none of these are failed or still running, then volume data might have been fully restored.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RichardHoch can you fix this typo in a follow up PR please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On it.

@RichardHoch RichardHoch mentioned this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 merge-review-in-progress Signifies that the merge review team is reviewing this PR OADP Label for all OADP PRs peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants