-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore errors and warnings #67803
Restore errors and warnings #67803
Conversation
🤖 Wed Feb 14 14:21:24 - Prow CI generated the docs preview: https://67803--ocpdocs-pr.netlify.app |
1238a36
to
1073c64
Compare
@kaovilai I made the changes you suggest. |
4.11 is now EOL, and we are no longer updating it. Please set the versions to 4.12+. |
b4ed659
to
d78cac6
Compare
@stillalearner Please review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/label OADP |
/label peer-review-in-progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few suggestions for your consideration; overall lgtm!
Also, please add the preview link in the PR desription.
/remove-label peer-review-in-progress |
If merge review looks good, please merge immediately. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick question
2def67a
to
42fbc31
Compare
@JoeAldinger: Fixed it. Good catch! |
I'll merge as soon as it builds @RichardHoch |
@RichardHoch: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/cherrypick enterprise-4.15 |
/cherrypick enterprise-4.14 |
/cherrypick enterprise-4.13 |
/cherrypick enterprise-4.12 |
@JoeAldinger: new pull request created: #71612 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@JoeAldinger: new pull request created: #71613 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@JoeAldinger: new pull request created: #71614 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@JoeAldinger: new pull request created: #71615 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
||
* If there are `Velero` errors, but no resource-specific errors, in the output of a `describe` command, it is possible that the restore completed without any actual problems in restoring workloads, but carefully validate post-restore applications. | ||
+ | ||
For example, if the output contains `PodVolumeRestore` or node sgent-related errors, check the status of `PodVolumeRestores` and `DataDownloads`. If none of these are failed or still running, then volume data might have been fully restored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RichardHoch can you fix this typo in a follow up PR please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On it.
OADP 1.3.0, OCP 4.12+
Resolves https://issues.redhat.com/browse/OADP-3057 by adding more information to the "Describe command" section of https://access.redhat.com/documentation/en-us/openshift_container_platform/4.14/html-single/backup_and_restore/index#migration-debugging-velero-resources_oadp-troubleshooting.
Preview: https://67803--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/troubleshooting#migration-debugging-velero-resources_oadp-troubleshooting {"Describe command," text following the example through the "Important" note]