Fix OADP-5183: Ensure containers are all using FallbackToLogsOnError in terminationMessagePolicy

[shubham-pampattiwar]

Why the changes were made

Ensure containers are all using FallbackToLogsOnError in terminationMessagePolicy

Related JIRA: https://issues.redhat.com/browse/OADP-5183

How to test the changes made

• Install Operator and create basic DPA deploying Velero, Node-Agent and NAC Pods, alongside the OADP Operator pod in install NS
• Use the Certsuite tool to test the changes: https://github.com/redhat-best-practices-for-k8s/certsuite
• You need to check wether the PR changes pass for the observability test: observability-termination-policy
• Follow the setup docs: https://redhat-best-practices-for-k8s.github.io/certsuite/configuration/
• And then run the relevant test for our pods, For this PR to be tested, run:

spampatt@spampatt-mac certsuite [main]$ ./certsuite run -l "observability-termination-policy" -c certsuite_config.yml

• You can see results under the results/ (logs, results html etc)
• Should look like:

[openshift-ci-robot]

@shubham-pampattiwar: This pull request references OADP-5183 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

Why the changes were made

Ensure containers are all using FallbackToLogsOnError in terminationMessagePolicy

Related JIRA: https://issues.redhat.com/browse/OADP-5183

How to test the changes made

• Install Operator and create basic DPA deploying Velero, Node-Agent and NAC Pods, alongside the OADP Operator pod in install NS
• Use the Certsuite tool to test the changes: https://github.com/redhat-best-practices-for-k8s/certsuite
• You need to check wether the PR changes pass for the observability test: observability-termination-policy
• Follow the setup docs: https://redhat-best-practices-for-k8s.github.io/certsuite/configuration/
• And then run the relevant test for our pods, For this PR to be tested, run:

spampatt@spampatt-mac certsuite [main]$ ./certsuite run -l "observability-termination-policy" -c certsuite_config.yml

• You can see results under the results/ (logs, results html etc)
• Should look like:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shubham-pampattiwar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@shubham-pampattiwar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/4.16-e2e-test-aws	d55863c	link	true	/test 4.16-e2e-test-aws
ci/prow/4.17-e2e-test-kubevirt-aws	d55863c	link	true	/test 4.17-e2e-test-kubevirt-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[mateusoliveira43]

here would not be better to use setContainerDefaults function from controllers/common.go?

[mateusoliveira43]

need to apply this also to if len(deploymentObject.Spec.Template.Spec.Containers) == 0 case