Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OLS-1098: Metric Server Enforce TLS Security Profile #500

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

OLS-1098: Metric Server Enforce TLS Security Profile #500

wants to merge 3 commits into from

Conversation

raptorsun
Copy link
Contributor

@raptorsun raptorsun commented Oct 18, 2024 •
edited
Loading

This PR is baded on #481 , if we merge this PR, we can close the PR#481

Description

When operator starts, it tries to fetch TLS Security Profile from the OLSConfig CR or the APIServer CR.
If neither of these 2 CRs defines TLS Security Profile, the default "Intermediate" level TLS Security Profile will be used.
The operator is baded on controller-runtime that is not capable of restarting the metrics server on running. The user should manually restart the operator pod if it wants to enforce the new TLS Security Profile.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 18, 2024 •
edited by openshift-ci bot
Loading

@raptorsun: This pull request references OLS-1098 which is a valid jira issue.

In response to this:

Description

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 18, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from raptorsun. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@raptorsun raptorsun changed the title [WIP] OLS-1098: Metric Server Enforce TLS Security Profile OLS-1098: Metric Server Enforce TLS Security Profile Oct 18, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 18, 2024 •
edited by openshift-ci bot
Loading

@raptorsun: This pull request references OLS-1098 which is a valid jira issue.

In response to this:

Description

When operator starts, it tries to fetch TLS Security Profile from the OLSConfig CR or the APIServer CR.
If neither of these 2 CRs defines TLS Security Profile, the default "Intermediate" level TLS Security Profile will be used.
The operator is baded on controller-runtime that is not capable of restarting the metrics server on running. The user should manually restart the operator pod if it wants to enforce the new TLS Security Profile.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 18, 2024 •
edited by openshift-ci bot
Loading

@raptorsun: This pull request references OLS-1098 which is a valid jira issue.

In response to this:

Description

When operator starts, it tries to fetch TLS Security Profile from the OLSConfig CR or the APIServer CR.
If neither of these 2 CRs defines TLS Security Profile, the default "Intermediate" level TLS Security Profile will be used.
The operator is baded on controller-runtime that is not capable of restarting the metrics server on running. The user should manually restart the operator pod if it wants to enforce the new TLS Security Profile.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 18, 2024 •
edited by openshift-ci bot
Loading

@raptorsun: This pull request references OLS-1098 which is a valid jira issue.

In response to this:

This PR is baded on #481 , if we merge this PR, we can close the PR#481

Description

When operator starts, it tries to fetch TLS Security Profile from the OLSConfig CR or the APIServer CR.
If neither of these 2 CRs defines TLS Security Profile, the default "Intermediate" level TLS Security Profile will be used.
The operator is baded on controller-runtime that is not capable of restarting the metrics server on running. The user should manually restart the operator pod if it wants to enforce the new TLS Security Profile.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 18, 2024

@raptorsun: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees Awaiting requested review from bparees

@joshuawilson joshuawilson Awaiting requested review from joshuawilson

Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raptorsun @openshift-ci-robot