Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency upgrade #427

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

raptorsun
Copy link
Contributor

@raptorsun raptorsun commented Sep 21, 2024

Blocked

UBI go-toolset does not provide golang v1.22+, k8s.io/* packages cannot be upgraded above 0.30

Description

Upgraded packages:

  • k8s.io/api v0.31.1
  • k8s.io/apimachinery v0.31.1
  • k8s.io/client-go v0.31.1
  • sigs.k8s.io/controller-runtime v0.19.0
  • prometheus-operator v0.76.2

This PR replaces:

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

…k8s.io/client-go v0.31.1, sigs.k8s.io/controller-runtime v0.19.0, prometheus-operator v0.76.2

Signed-off-by: Haoyu Sun <[email protected]>
Copy link

openshift-ci bot commented Sep 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from raptorsun. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Sep 26, 2024

@raptorsun: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/bundle-e2e-4-16 155837a link true /test bundle-e2e-4-16
ci/prow/bundle-e2e-4-15 155837a link true /test bundle-e2e-4-15
ci/prow/ci-index-lightspeed-bundle-test 155837a link true /test ci-index-lightspeed-bundle-test
ci/prow/images 155837a link true /test images
ci/prow/bundle-e2e-4-17 155837a link true /test bundle-e2e-4-17

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants