-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OLS-385: User provided certs #411
base: main
Are you sure you want to change the base?
Conversation
@raptorsun: This pull request references OLS-385 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/hold |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ee6fd91
to
419bba2
Compare
419bba2
to
bf5cab2
Compare
/unhold |
@raptorsun: This pull request references OLS-385 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@raptorsun: This pull request references OLS-385 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/test bundle-e2e-4-16 |
1 similar comment
/test bundle-e2e-4-16 |
bf5cab2
to
cb520d6
Compare
/test bundle-e2e-4-15 |
/lgtm |
cb520d6
to
d1fb48c
Compare
d1fb48c
to
04636a4
Compare
/lgtm |
04636a4
to
3108dba
Compare
New changes are detected. LGTM label has been removed. |
@raptorsun: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
User can provide TLS key and certificates for the communication between console proxy and the application HTTPS endpoint:
.spec.ols.deployment.console.caCertificate
.spec.ols.tlsConfig
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing
olsconfig.yaml
secret-user-app-tls.yaml
Send query from UI chatbox, works just as perfect as using the default TLS credentials provided by
service-ca
operator.