Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSOLE-4119: Convert PDB form deprecated component to Select #14310

Merged
merged 1 commit into from
Sep 25, 2024
Merged

CONSOLE-4119: Convert PDB form deprecated component to Select #14310

merged 1 commit into from
Sep 25, 2024

Conversation

sg00dwin
Copy link
Member

pdb-form

@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Sep 18, 2024
@cyril-ui-developer
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2024
@sg00dwin sg00dwin changed the title CONSOLE 4119: Convert PDB form deprecated component to Select CONSOLE-4119: Convert PDB form deprecated component to Select Sep 20, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 20, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 20, 2024 •
edited by openshift-ci bot
Loading

@sg00dwin: This pull request references CONSOLE-4119 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

pdb-form

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sg00dwin
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 20, 2024 •
edited by openshift-ci bot
Loading

@sg00dwin: This pull request references CONSOLE-4119 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sg00dwin
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 20, 2024 •
edited by openshift-ci bot
Loading

@sg00dwin: This pull request references CONSOLE-4119 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sg00dwin
Copy link
Member Author

Tech debt so manually adding labels:
/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Sep 23, 2024
@sg00dwin
Copy link
Member Author

QE Approver:
/assign @yapei

@yanpzhan
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 24, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 24, 2024 •
edited by openshift-ci bot
Loading

@sg00dwin: This pull request references CONSOLE-4119 which is a valid jira issue.

In response to this:

pdb-form

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jhadvig
jhadvig approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyril-ui-developer, jhadvig, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 25, 2024

@sg00dwin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4dd73aa into openshift:master Sep 25, 2024
6 checks passed
@sg00dwin sg00dwin deleted the convert-4119-PDBform branch September 25, 2024 14:32
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console
This PR has been included in build openshift-enterprise-console-container-v4.18.0-202409251710.p0.g4dd73aa.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig approved these changes

@spadgett spadgett Awaiting requested review from spadgett

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

@yapei yapei

@cyril-ui-developer cyril-ui-developer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sg00dwin @cyril-ui-developer @openshift-ci-robot @yanpzhan @openshift-bot @jhadvig @yapei