-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ODC-7655: Migrate SelectVariant.Typeahead
SelectInputField
s to PF5
#14305
ODC-7655: Migrate SelectVariant.Typeahead
SelectInputField
s to PF5
#14305
Conversation
@logonoff: This pull request references ODC-7655 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
765128f
to
db60503
Compare
f0af6b8
to
5270ffb
Compare
Tech debt that is not customer facing, so manually adding labels |
2afb71b
to
ce518f0
Compare
/retest |
b9b7f94
to
26ab099
Compare
26ab099
to
3758c39
Compare
/unhold |
8d9f3d7
to
673a35e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
673a35e
to
38d8c72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff, vikram-raj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Verified on a cluster with admin and non-admin users Screencast.from.2024-10-18.21-13-29.mp4/label qe-approved |
@logonoff: This pull request references ODC-7655 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@logonoff: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-console |
Fixes:
https://issues.redhat.com/browse/ODC-7655
Solution Description:
Migrate all SelectInputFields that use the typeahead variant to PF5. Other variants will get other PRs as I am splitting up this component
I commented out the input validation UI because it is not supported in our currently installed version of PatternFly
Screen shots / Gifs for design review:
Demo:
Screencast.from.2024-09-17.14-28-14.mp4
Unit test coverage report:
unchanged
Test setup:
n/a
Browser conformance:
This pr is 5/? of ODC-7655 story as each file is being split into a separate PR.