Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODC-7655: Migrate SelectVariant.Typeahead SelectInputFields to PF5 #14305

Merged

Conversation

logonoff
Copy link
Member

Fixes:

https://issues.redhat.com/browse/ODC-7655

Solution Description:

Migrate all SelectInputFields that use the typeahead variant to PF5. Other variants will get other PRs as I am splitting up this component

I commented out the input validation UI because it is not supported in our currently installed version of PatternFly

Screen shots / Gifs for design review:

Demo:

Screencast.from.2024-09-17.14-28-14.mp4

Unit test coverage report:

unchanged

Test setup:

n/a

Browser conformance:

  • Chrome
  • Firefox
  • Safari

This pr is 5/? of ODC-7655 story as each file is being split into a separate PR.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 17, 2024

@logonoff: This pull request references ODC-7655 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Fixes:

https://issues.redhat.com/browse/ODC-7655

Solution Description:

Migrate all SelectInputFields that use the typeahead variant to PF5. Other variants will get other PRs as I am splitting up this component

I commented out the input validation UI because it is not supported in our currently installed version of PatternFly

Screen shots / Gifs for design review:

Demo:

Screencast.from.2024-09-17.14-28-14.mp4

Unit test coverage report:

unchanged

Test setup:

n/a

Browser conformance:

  • Chrome
  • Firefox
  • Safari

This pr is 5/? of ODC-7655 story as each file is being split into a separate PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 17, 2024
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dev-console Related to dev-console component/knative Related to knative-plugin component/shared Related to console-shared kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Sep 17, 2024
@logonoff logonoff force-pushed the ODC-7655-SingleTypeaheadField branch 3 times, most recently from f0af6b8 to 5270ffb Compare September 19, 2024 16:16
@logonoff
Copy link
Member Author

/hold

I've decided to make this one the PR which will remove SelectInputField, so it must merge after #14287 and #14309

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2024
@logonoff
Copy link
Member Author

Tech debt that is not customer facing, so manually adding labels
/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Sep 20, 2024
@logonoff logonoff force-pushed the ODC-7655-SingleTypeaheadField branch 2 times, most recently from 2afb71b to ce518f0 Compare September 24, 2024 19:52
@logonoff
Copy link
Member Author

/retest

@logonoff logonoff force-pushed the ODC-7655-SingleTypeaheadField branch 3 times, most recently from b9b7f94 to 26ab099 Compare September 27, 2024 16:25
@logonoff logonoff force-pushed the ODC-7655-SingleTypeaheadField branch from 26ab099 to 3758c39 Compare October 4, 2024 13:36
@logonoff
Copy link
Member Author

logonoff commented Oct 4, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2024
@logonoff logonoff force-pushed the ODC-7655-SingleTypeaheadField branch 2 times, most recently from 8d9f3d7 to 673a35e Compare October 4, 2024 17:16
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice one issue here. When I focus on the field it open the empty option dropdown. and once I start typing I can see the option.

image

Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2024
Copy link
Contributor

openshift-ci bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2024
@sanketpathak
Copy link
Contributor

Verified on a cluster with admin and non-admin users

Screencast.from.2024-10-18.21-13-29.mp4

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 21, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 21, 2024

@logonoff: This pull request references ODC-7655 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Fixes:

https://issues.redhat.com/browse/ODC-7655

Solution Description:

Migrate all SelectInputFields that use the typeahead variant to PF5. Other variants will get other PRs as I am splitting up this component

I commented out the input validation UI because it is not supported in our currently installed version of PatternFly

Screen shots / Gifs for design review:

Demo:

Screencast.from.2024-09-17.14-28-14.mp4

Unit test coverage report:

unchanged

Test setup:

n/a

Browser conformance:

  • Chrome
  • Firefox
  • Safari

This pr is 5/? of ODC-7655 story as each file is being split into a separate PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Oct 21, 2024

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit fee5f3f into openshift:master Oct 21, 2024
6 checks passed
@logonoff logonoff deleted the ODC-7655-SingleTypeaheadField branch October 21, 2024 17:42
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console
This PR has been included in build openshift-enterprise-console-container-v4.18.0-202410212042.p0.gfee5f3f.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/knative Related to knative-plugin component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants