-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hot reload of plugin is broken in 4.14 #57
Comments
This could be the same as https://issues.redhat.com/browse/OCPBUGS-24607 |
Had the same experience with hot reload. Changing from latest to 4.13 solved the problem. |
Because the dev server has cache enabled thus when the plugin manifest is requested the second time it returns empty content, causing the plugin reload to fail. The fix is to disable the cache on the dev server.
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
/lifecycle frozen @vojtechszocs FYI since you own the JIRA issue. I was testing a new plugin created with the template and the origin-console:latest image yesterday, and hot reloading was working for me. @iocanel Do you have a reproducer for us? |
Because the dev server has cache enabled thus when the plugin manifest is requested the second time it returns empty content, causing the plugin reload to fail. The fix is to disable the cache on the dev server.
After 4.14 release of OpenShift I started experiencing issues with hot reloading of console plugin when developing.
After any change in my plugin code, I was getting a 404 when trying to access the plugin, so I had to do the full (yarn run start and yarn run start-console thing again).
Logs seems clear with no indication of a problem. After exploring the browser console I noticed that the second time browser tries to fetch the console manifest (e.g. http://localhost:9000/api/plugins/quarkus-openshift-console-plugin/plugin-manifest.json) it gets a blank response back.
After rolling back to 4.13 (by changing the start-console.sh script to use 4.13 instead of latest) the issue seems fixed.
The text was updated successfully, but these errors were encountered: