Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot reload of plugin is broken in 4.14 #57

Open
iocanel opened this issue Dec 14, 2023 · 5 comments
Open

Hot reload of plugin is broken in 4.14 #57

iocanel opened this issue Dec 14, 2023 · 5 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@iocanel
Copy link

iocanel commented Dec 14, 2023

After 4.14 release of OpenShift I started experiencing issues with hot reloading of console plugin when developing.
After any change in my plugin code, I was getting a 404 when trying to access the plugin, so I had to do the full (yarn run start and yarn run start-console thing again).

Logs seems clear with no indication of a problem. After exploring the browser console I noticed that the second time browser tries to fetch the console manifest (e.g. http://localhost:9000/api/plugins/quarkus-openshift-console-plugin/plugin-manifest.json) it gets a blank response back.

After rolling back to 4.13 (by changing the start-console.sh script to use 4.13 instead of latest) the issue seems fixed.

@spadgett
Copy link
Member

/cc @vojtechszocs @jhadvig

This could be the same as https://issues.redhat.com/browse/OCPBUGS-24607

@Javatar81
Copy link

Had the same experience with hot reload. Changing from latest to 4.13 solved the problem.

gaohoward pushed a commit to gaohoward/console-plugin-template that referenced this issue Feb 20, 2024
Because the dev server has cache enabled thus when the plugin manifest is
requested the second time it returns empty content, causing the plugin
reload to fail. The fix is to disable the cache on the dev server.
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 20, 2024
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 19, 2024
@spadgett
Copy link
Member

/lifecycle frozen

@vojtechszocs FYI since you own the JIRA issue.

I was testing a new plugin created with the template and the origin-console:latest image yesterday, and hot reloading was working for me. @iocanel Do you have a reproducer for us?

@openshift-ci openshift-ci bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Apr 19, 2024
gaohoward pushed a commit to gaohoward/console-plugin-template that referenced this issue Apr 22, 2024
Because the dev server has cache enabled thus when the plugin manifest is
requested the second time it returns empty content, causing the plugin
reload to fail. The fix is to disable the cache on the dev server.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

4 participants