Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable remember-ok-to-test by default #1798

Open
arewm opened this issue Oct 28, 2024 · 0 comments
Open

Disable remember-ok-to-test by default #1798

arewm opened this issue Oct 28, 2024 · 0 comments
Labels
feature New feature or request

Comments

@arewm
Copy link

arewm commented Oct 28, 2024

When /ok-to-test is remembered, it is possible for an external contributor to gain trust with a reasonable code change and then push a malicious change which is targeted at the build system (i.e. secret exfiltration).

In order to mitigate this risk, PAC should configure this to false by default and documentation should be added to highlight the risk. Installations would then have to explicitly set this to true to accept the potential risk of the configuration.

@chmouel chmouel added the feature New feature or request label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Development

No branches or pull requests

2 participants