-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add query, langType, status, error in AsyncQueryJobMetadata #2958
Merged
ykmr1224
merged 6 commits into
opensearch-project:main
from
ykmr1224:dqs/add-query-status
Sep 9, 2024
Merged
Add query, langType, status, error in AsyncQueryJobMetadata #2958
ykmr1224
merged 6 commits into
opensearch-project:main
from
ykmr1224:dqs/add-query-status
Sep 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoyuki Morita <[email protected]>
ykmr1224
added
backport 2.x
maintenance
Improves code quality, but not the product
labels
Aug 30, 2024
ykmr1224
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG and
LantaoJin
as code owners
August 30, 2024 22:35
vamsi-amazon
reviewed
Sep 4, 2024
async-query-core/src/main/java/org/opensearch/sql/spark/asyncquery/model/QueryState.java
Show resolved
Hide resolved
vamsi-amazon
reviewed
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vamsi-amazon
previously approved these changes
Sep 4, 2024
seankao-az
previously approved these changes
Sep 4, 2024
Signed-off-by: Tomoyuki MORITA <[email protected]>
ykmr1224
dismissed stale reviews from seankao-az and vamsi-amazon
via
September 4, 2024 21:27
962f411
seankao-az
previously approved these changes
Sep 4, 2024
Signed-off-by: Tomoyuki MORITA <[email protected]>
# Conflicts: # async-query-core/src/test/java/org/opensearch/sql/spark/asyncquery/AsyncQueryCoreIntegTest.java
Signed-off-by: Tomoyuki Morita <[email protected]>
vamsi-amazon
previously approved these changes
Sep 6, 2024
seankao-az
previously approved these changes
Sep 6, 2024
Signed-off-by: Tomoyuki MORITA <[email protected]>
ykmr1224
dismissed stale reviews from seankao-az and vamsi-amazon
via
September 6, 2024 20:33
4486a44
seankao-az
approved these changes
Sep 9, 2024
vamsi-amazon
approved these changes
Sep 9, 2024
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-2958-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1b1a1b5e97def94504a75ffaedbd5d72ffc9614a
# Push it to GitHub
git push --set-upstream origin backport/backport-2958-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x Then, create a pull request where the |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Add query, langType, status, error in AsyncQueryJobMetadata Signed-off-by: Tomoyuki Morita <[email protected]> * Fix test Signed-off-by: Tomoyuki Morita <[email protected]> --------- Signed-off-by: Tomoyuki Morita <[email protected]> Signed-off-by: Tomoyuki MORITA <[email protected]> (cherry picked from commit 1b1a1b5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ykmr1224
pushed a commit
that referenced
this pull request
Sep 9, 2024
…3003) * Add query, langType, status, error in AsyncQueryJobMetadata * Fix test --------- (cherry picked from commit 1b1a1b5) Signed-off-by: Tomoyuki Morita <[email protected]> Signed-off-by: Tomoyuki MORITA <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
opensearch-project/opensearch-spark#602
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.