Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job scheduler plugin to test cluster #2957

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

noCharger
Copy link
Collaborator

@noCharger noCharger commented Aug 30, 2024

Description

Add job scheduler plugin to test cluster, to work with gradlew run and debug mode

Test

Before:

> Task :opensearch-sql-plugin:run FAILED
Exec output and error:
| Output for ./bin/opensearch-plugin:-> Installing file:/local/home/clingzhi/workplace/sql/plugin/build/distributions/opensearch-sql-3.0.0.0-SNAPSHOT.zip
| -> Downloading file:/local/home/clingzhi/workplace/sql/plugin/build/distributions/opensearch-sql-3.0.0.0-SNAPSHOT.zip
| -> Failed installing file:/local/home/clingzhi/workplace/sql/plugin/build/distributions/opensearch-sql-3.0.0.0-SNAPSHOT.zip
| -> Rolling back file:/local/home/clingzhi/workplace/sql/plugin/build/distributions/opensearch-sql-3.0.0.0-SNAPSHOT.zip
| -> Rolled back file:/local/home/clingzhi/workplace/sql/plugin/build/distributions/opensearch-sql-3.0.0.0-SNAPSHOT.zip
| Exception in thread "main" java.lang.IllegalArgumentException: Missing plugin [opensearch-job-scheduler], dependency of [opensearch-sql]
|       at org.opensearch.plugins.PluginsService.addSortedBundle(PluginsService.java:527)
|       at org.opensearch.plugins.PluginsService.sortBundles(PluginsService.java:495)
|       at org.opensearch.plugins.InstallPluginCommand.jarHellCheck(InstallPluginCommand.java:855)
|       at org.opensearch.plugins.InstallPluginCommand.loadPluginInfo(InstallPluginCommand.java:829)
|       at org.opensearch.plugins.InstallPluginCommand.installPlugin(InstallPluginCommand.java:874)
|       at org.opensearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:276)
|       at org.opensearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:250)
|       at org.opensearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:104)
|       at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
|       at org.opensearch.cli.MultiCommand.execute(MultiCommand.java:104)
|       at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
|       at org.opensearch.cli.Command.main(Command.java:101)
|       at org.opensearch.plugins.PluginCli.main(PluginCli.java:66)

FAILURE: Build failed with an exception.

After:

...
[2024-08-30T14:00:38,537][INFO ][o.o.j.JobSchedulerPlugin ] [integTest-0] Loaded scheduler extension: async-query-scheduler, index: .async-query-scheduler
...
[2024-08-30T14:00:38,546][INFO ][o.o.p.PluginsService     ] [integTest-0] loaded plugin [opensearch-job-scheduler]
[2024-08-30T14:00:38,546][INFO ][o.o.p.PluginsService     ] [integTest-0] loaded plugin [opensearch-sql]...
...

[2024-08-30T14:00:42,788][INFO ][o.o.g.GatewayService     ] [integTest-0] recovered [0] indices into cluster_state
[2024-08-30T14:00:43,181][DEBUG][o.o.c.c.ElectionSchedulerFactory] [integTest-0] scheduleNextElection{gracePeriod=500ms, thisAttempt=1, maxDelayMillis=200, delayMillis=532, ElectionScheduler{attempt=2, ElectionSchedulerFactory{initialTimeout=100ms, backoffTime=100ms, maxTimeout=10s}}} not starting election
[2024-08-30T14:05:42,561][INFO ][o.o.j.s.JobSweeper       ] [integTest-0] Running full sweep
[2024-08-30T14:10:42,562][INFO ][o.o.j.s.JobSweeper       ] [integTest-0] Running full sweep
<============-> 98% EXECUTING [10m 17s]
> :opensearch-sql-plugin:run

Check List

  • New functionality includes testing.
  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@manasvinibs
Copy link
Member

Are grammar files changes needed?

@noCharger
Copy link
Collaborator Author

Are grammar files changes needed?

I think these are auto included by syncing from spark repo

@noCharger noCharger mentioned this pull request Sep 4, 2024
5 tasks
@noCharger noCharger added enhancement New feature or request backport 2.x labels Sep 26, 2024
@noCharger noCharger merged commit c1e623d into opensearch-project:main Sep 27, 2024
14 of 16 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 27, 2024
Signed-off-by: Louis Chu <[email protected]>
(cherry picked from commit c1e623d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants