Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for S3GlueConnector. #2229

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

vamsi-amazon
Copy link
Member

@vamsi-amazon vamsi-amazon commented Oct 5, 2023

Description

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #2229 (2538b6e) into main (5f76037) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 2538b6e differs from pull request most recent head c176525. Consider uploading reports for the commit c176525 to get more accurate results

@@            Coverage Diff            @@
##               main    #2229   +/-   ##
=========================================
  Coverage     96.34%   96.34%           
  Complexity     4725     4725           
=========================================
  Files           439      439           
  Lines         12682    12682           
  Branches        871      871           
=========================================
  Hits          12219    12219           
  Misses          454      454           
  Partials          9        9           
Flag Coverage Δ
sql-engine 96.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Vamsi Manohar <[email protected]>
@penghuo penghuo merged commit 45da40f into opensearch-project:main Oct 5, 2023
19 of 20 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 5, 2023
Signed-off-by: Vamsi Manohar <[email protected]>
(cherry picked from commit 45da40f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 5, 2023
Signed-off-by: Vamsi Manohar <[email protected]>
(cherry picked from commit 45da40f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
YANG-DB pushed a commit that referenced this pull request Oct 5, 2023
(cherry picked from commit 45da40f)

Signed-off-by: Vamsi Manohar <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
penghuo pushed a commit that referenced this pull request Oct 5, 2023
(cherry picked from commit 45da40f)

Signed-off-by: Vamsi Manohar <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.11 documentation Improvements or additions to documentation Flint v2.11.0 Issues targeting release v2.11.0
Projects
Status: Planned work items
Development

Successfully merging this pull request may close these issues.

4 participants