Fix backport branch name is not correct #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
ohltyler,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90,
zhichao-aws and
joshuali925
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
=========================================
Coverage 81.76% 81.76%
Complexity 86 86
=========================================
Files 8 8
Lines 521 521
Branches 70 70
=========================================
Hits 426 426
Misses 54 54
Partials 41 41 ☔ View full report in Codecov by Sentry. |
|
Backport is failing, do we need to handle this failure? |
line 39 will handle this. line12-21 will disable backport workflow run when creating a normal PR. |
zhichao-aws
approved these changes
Dec 27, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 27, 2023
Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 05c8fe0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhichao-aws
added a commit
that referenced
this pull request
Dec 27, 2023
* Fix backport branch name is not correct (#69) Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 05c8fe0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * include fix in #70 Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: zhichao-aws <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: zhichao-aws <[email protected]>
yuye-aws
pushed a commit
to yuye-aws/skills
that referenced
this pull request
Apr 26, 2024
…oject#71) * Fix backport branch name is not correct (opensearch-project#69) Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 05c8fe0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * include fix in opensearch-project#70 Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: zhichao-aws <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: zhichao-aws <[email protected]> Signed-off-by: yuye-aws <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The correct backport branch name should be something like
backport/backport-41-to-2.xotherwise, backport branch will not get deleted when merged by
delete_backport_branchworkflowIssues Resolved
An example of wrong backportn name PR #68
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.