Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unit test failing due to anomaly detector update #412

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

yuye-aws
Copy link
Member

@yuye-aws yuye-aws commented Sep 25, 2024

Description

Resolves unit test failure and building error. AD commit: opensearch-project/anomaly-detection@062db14

Related Issues

Resolves unit test failure and building error.

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@yuye-aws
Copy link
Member Author

@zane-neo
Copy link
Collaborator

Anyone knows how to fix: https://github.com/opensearch-project/skills/actions/runs/11030417880/job/30634925758?pr=412?

It's not a blocking issue, we can take care of this in another PR.

@zane-neo zane-neo merged commit afa74c0 into opensearch-project:main Sep 26, 2024
8 of 9 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/skills/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/skills/backport-2.x
# Create a new branch
git switch --create backport/backport-412-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 afa74c0d6766b5481532b3934cddbfc554aa0826
# Push it to GitHub
git push --set-upstream origin backport/backport-412-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/skills/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-412-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants