Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add visualization tool #41
Add visualization tool #41
Changes from 2 commits
5b2a8a9
d77c43d
9515479
53545c6
e24fc7d
69344de
d64ac01
4c7399d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 58 in src/main/java/org/opensearch/agent/ToolPlugin.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/ToolPlugin.java#L58
Check warning on line 64 in src/main/java/org/opensearch/agent/ToolPlugin.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/ToolPlugin.java#L64
Check warning on line 34 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L34
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does
3
needs to be static? Can't we do like 3 by default but the input is dynamic?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good suggestion, update the number to dynamic setting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be update the description as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the specific number in description has been removed. now it's
"Use this tool to find user created visualizations. This tool takes the visualization name as input and returns the matching visualizations"
Check warning on line 44 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L44
Check warning on line 46 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L46
Check warning on line 55 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L52-L55
Check warning on line 61 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L59-L61
Check warning on line 65 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L63-L65
Check warning on line 67 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L67
Check warning on line 72 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L70-L72
Check warning on line 79 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L74-L79
Check warning on line 81 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L81
Check warning on line 83 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L83
Check warning on line 85 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L85
Check warning on line 90 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L90
Check warning on line 92 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L92
Check warning on line 94 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L94
Check warning on line 96 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L96
Check warning on line 100 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L100
Check warning on line 103 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L102-L103
Check warning on line 105 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L105
Check warning on line 110 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L110
Check warning on line 115 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L115
Check warning on line 120 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L120
Check warning on line 126 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L125-L126
Check warning on line 130 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L130
Check warning on line 136 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L135-L136
Check warning on line 143 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L143
Check warning on line 150 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L150
Check warning on line 152 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L152
Check warning on line 154 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L154
Check warning on line 157 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L156-L157
Check warning on line 163 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L162-L163
Check warning on line 168 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L168
Check warning on line 173 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Codecov / codecov/patch
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L173