Add visualization tool #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
ohltyler,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90,
zhichao-aws and
joshuali925
as code owners
|
please help to add backport 2.x label also |
Signed-off-by: Hailong Cui <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
============================================
+ Coverage 44.41% 50.35% +5.94%
- Complexity 30 38 +8
============================================
Files 6 7 +1
Lines 358 423 +65
Branches 42 49 +7
============================================
+ Hits 159 213 +54
- Misses 178 187 +9
- Partials 21 23 +2 ☔ View full report in Codecov by Sentry. |
dbwiddis
reviewed
Dec 21, 2023
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Outdated
Show resolved
Hide resolved
src/test/resources/org/opensearch/agent/tools/visualization.json
Outdated
Show resolved
Hide resolved
src/test/resources/org/opensearch/agent/tools/visualization_not_found.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
zane-neo
reviewed
Dec 22, 2023
src/main/java/org/opensearch/agent/tools/VisualizationsTool.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
zane-neo
approved these changes
Dec 22, 2023
|
Need to resolve the conflict |
dhrubo-os
reviewed
Dec 22, 2023
|
|
||
| public static final String SAVED_OBJECT_TYPE = "visualization"; | ||
| private static final String DEFAULT_DESCRIPTION = | ||
| "Use this tool to find user created visualizations. This tool takes the visualization name as input and returns the first 3 matching visualizations"; |
There was a problem hiding this comment.
Does 3 needs to be static? Can't we do like 3 by default but the input is dynamic?
There was a problem hiding this comment.
good suggestion, update the number to dynamic setting.
There was a problem hiding this comment.
May be update the description as well?
There was a problem hiding this comment.
the specific number in description has been removed. now it's "Use this tool to find user created visualizations. This tool takes the visualization name as input and returns the matching visualizations"
dhrubo-os
reviewed
Dec 22, 2023
src/main/java/org/opensearch/agent/tools/SearchAnomalyDetectorsTool.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
resolved |
dhrubo-os
approved these changes
Dec 26, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 27, 2023
* Visualization Tool Signed-off-by: Hailong Cui <[email protected]> * fix build failure due to forbiddenApis Signed-off-by: Hailong Cui <[email protected]> * Address review comments Signed-off-by: Hailong Cui <[email protected]> * spotlessApply Signed-off-by: Hailong Cui <[email protected]> * update default tool name Signed-off-by: Hailong Cui <[email protected]> * update number of visualization be dynamic Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 3774eb9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhichao-aws
pushed a commit
that referenced
this pull request
Dec 27, 2023
* Visualization Tool * fix build failure due to forbiddenApis * Address review comments * spotlessApply * update default tool name * update number of visualization be dynamic --------- (cherry picked from commit 3774eb9) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yuye-aws
pushed a commit
to yuye-aws/skills
that referenced
this pull request
Apr 26, 2024
* Visualization Tool * fix build failure due to forbiddenApis * Address review comments * spotlessApply * update default tool name * update number of visualization be dynamic --------- (cherry picked from commit 3774eb9) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: yuye-aws <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Visualization Tool, coming from opensearch-project/ml-commons#1649
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.