Fix warning and format issue for CreateAnomalyDetectorTool #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gaobinlong <[email protected]>
gaobinlong
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
ohltyler,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90,
zhichao-aws and
joshuali925
as code owners
zane-neo
approved these changes
Jul 17, 2024
qianheng-aws
pushed a commit
to qianheng-aws/skills
that referenced
this pull request
Jul 25, 2024
…h-project#358) Signed-off-by: gaobinlong <[email protected]>
gaobinlong
added a commit
to gaobinlong/skills
that referenced
this pull request
Sep 3, 2024
* Add CreateAnomalyDetectorTool Signed-off-by: gaobinlong <[email protected]> * Optimize some code Signed-off-by: gaobinlong <[email protected]> * Fix test failure Signed-off-by: gaobinlong <[email protected]> * Optimize exception Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> Fix warning and format issue for CreateAnomalyDetectorTool (opensearch-project#358) Signed-off-by: gaobinlong <[email protected]> Add includeFields parameter to the method extractFieldNamesTypes (opensearch-project#376) * Add includeFields parameter to the method extractFieldNamesTypes Signed-off-by: gaobinlong <[email protected]> * Remove empty line Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> Optimize the prompt for create anomaly detector tool Signed-off-by: gaobinlong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow-up of #348, there're some warning and format issue existing in the code of CreateAnomalyDetectorTool, we need to fix them.
Backport to 2.x is not needed because the same issue were fixed in 2.x branch.
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.