Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add execute field #146

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Conversation

xinyual
Copy link
Collaborator

@xinyual xinyual commented Jan 25, 2024

Description

Add execute so we can decide whether to execute PPL

Issues Resolved

(#138)

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: xinyual <[email protected]>
Signed-off-by: xinyual <[email protected]>
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2028247) 80.73% compared to head (e8d1799) 80.83%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #146      +/-   ##
============================================
+ Coverage     80.73%   80.83%   +0.09%     
- Complexity      198      199       +1     
============================================
  Files            13       13              
  Lines          1028     1033       +5     
  Branches        134      135       +1     
============================================
+ Hits            830      835       +5     
  Misses          146      146              
  Partials         52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zane-neo zane-neo merged commit 16a26ce into opensearch-project:main Jan 25, 2024
13 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 25, 2024
* add execute field

Signed-off-by: xinyual <[email protected]>

* apply spotless

Signed-off-by: xinyual <[email protected]>

---------

Signed-off-by: xinyual <[email protected]>
(cherry picked from commit 16a26ce)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
xinyual pushed a commit that referenced this pull request Jan 26, 2024
* add execute field



* apply spotless



---------


(cherry picked from commit 16a26ce)

Signed-off-by: xinyual <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yuye-aws pushed a commit to yuye-aws/skills that referenced this pull request Apr 26, 2024
* add execute field

* apply spotless

---------

(cherry picked from commit 16a26ce)

Signed-off-by: xinyual <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: yuye-aws <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants