[Backport 2.x] Include more return values for SearchAnomalyDetectorsTool and SearchMonitorsTool #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onitorsTool (opensearch-project#143) Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90 and
zhichao-aws
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #145 +/- ##
============================================
+ Coverage 80.78% 81.01% +0.22%
Complexity 197 197
============================================
Files 13 13
Lines 1015 1027 +12
Branches 134 134
============================================
+ Hits 820 832 +12
Misses 144 144
Partials 51 51 ☔ View full report in Codecov by Sentry. |
lezzago
approved these changes
Jan 24, 2024
yuye-aws
pushed a commit
to yuye-aws/skills
that referenced
this pull request
Apr 26, 2024
…ool and SearchMonitorsTool (opensearch-project#145) * Include more return values for SearchAnomalyDetectorsTool and SearchMonitorsTool (opensearch-project#143) Signed-off-by: Tyler Ohlsen <[email protected]> * 2.x changes Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: yuye-aws <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manual backport of #143 to account for 2.x-specific AD changes.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.