fix name bug #139
Merged
fix name bug #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xinyual <[email protected]>
Signed-off-by: xinyual <[email protected]>
xinyual
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
amitgalitz,
jackiehanyang,
owaiskazi19,
ohltyler,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90,
zhichao-aws and
joshuali925
as code owners
zane-neo
reviewed
Jan 22, 2024
| @@ -149,9 +149,12 @@ public <T> void run(Map<String, String> parameters, ActionListener<T> listener) | |||
| GetMappingsRequest getMappingsRequest = buildGetMappingRequest(indexName); | |||
| client.admin().indices().getMappings(getMappingsRequest, ActionListener.<GetMappingsResponse>wrap(getMappingsResponse -> { | |||
| Map<String, MappingMetadata> mappings = getMappingsResponse.getMappings(); | |||
| if (mappings.size() == 0) { | |||
| throw new IllegalArgumentException("No matching index with index name: " + indexName); | |||
There was a problem hiding this comment.
Seems we should useNo matching mapping with ..., is this index from user's input?
Signed-off-by: xinyual <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
============================================
- Coverage 80.83% 80.69% -0.15%
Complexity 195 195
============================================
Files 13 13
Lines 1002 1005 +3
Branches 133 134 +1
============================================
+ Hits 810 811 +1
- Misses 141 142 +1
- Partials 51 52 +1 ☔ View full report in Codecov by Sentry. |
zane-neo
approved these changes
Jan 22, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 23, 2024
* fix name bug Signed-off-by: xinyual <[email protected]> * apply spotless Signed-off-by: xinyual <[email protected]> * change error message Signed-off-by: xinyual <[email protected]> --------- Signed-off-by: xinyual <[email protected]> (cherry picked from commit 8074492) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
xinyual
pushed a commit
that referenced
this pull request
Jan 23, 2024
* fix name bug * apply spotless * change error message --------- (cherry picked from commit 8074492) Signed-off-by: xinyual <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yuye-aws
pushed a commit
to yuye-aws/skills
that referenced
this pull request
Apr 26, 2024
* fix name bug * apply spotless * change error message --------- (cherry picked from commit 8074492) Signed-off-by: xinyual <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: yuye-aws <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we use pattern, the return metadata map is <index_name>: <index_mapping>. So we need to use the name from mapping instead of pattern name.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.