Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] support customized search query tool #318

Open
zhichao-aws opened this issue Jun 6, 2024 · 3 comments
Open

[RFC] support customized search query tool #318

zhichao-aws opened this issue Jun 6, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@zhichao-aws
Copy link
Member

Is your feature request related to a problem?
In current implementation we only supports neural sparse tool and vectorDB tool, which build the search request by filling a fixed template. However, we have different use cases which can have complexed search queries. For example, search with conditions/filters, using hybrid query, using nested search(with chunking processor) etc

What solution would you like?
Implement a customized search tool, user can specify a search request template. The template accepts one parameter of search text. And RAG tool should also supports this customized search tool.

@zhichao-aws zhichao-aws added enhancement New feature or request untriaged labels Jun 6, 2024
@zhichao-aws zhichao-aws self-assigned this Jun 6, 2024
@dblock
Copy link
Member

dblock commented Jul 1, 2024

Thanks for opening this feature request.

[Catch All Triage - Attendees 1, 2, 3, 4, 5]

@dblock dblock removed the untriaged label Jul 1, 2024
@zane-neo
Copy link
Collaborator

This tool accepts a new parameter: template and the search text will be filled into the template and then the template is the request body, is this understanding correct? Is it possible that user wants not only the query text as input parameter?

@zhichao-aws
Copy link
Member Author

This tool accepts a new parameter: template and the search text will be filled into the template and then the template is the request body, is this understanding correct? Is it possible that user wants not only the query text as input parameter?

Yes this is the correct understanding. My initial thought was users may need to use complexed filters or search DSLs instead of a naive neural or neural_sparse query, so I created this RFC to collect feedbacks. But now it seems no user valiate this use case. We can hold this untill recieve feedbacks from users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants