Skip to content

Commit

Permalink
fix build failure due to forbiddenApis
Browse files Browse the repository at this point in the history
Signed-off-by: Hailong Cui <[email protected]>
  • Loading branch information
Hailong-am committed Dec 21, 2023
1 parent 5b2a8a9 commit d77c43d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ compileJava {
compileTestJava {
options.compilerArgs.addAll(["-processor", 'lombok.launch.AnnotationProcessorHider$AnnotationProcessor'])
}

forbiddenApisTest.ignoreFailures = true

opensearchplugin {
name 'skills'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
package org.opensearch.agent.tools;

import java.util.Arrays;
import java.util.Locale;
import java.util.Map;
import java.util.Optional;

Expand Down Expand Up @@ -74,7 +75,7 @@ public void onResponse(SearchResponse searchResponse) {
String id = trimIdPrefix(h.getId());
Map<String, String> visMap = (Map<String, String>) h.getSourceAsMap().get(SAVED_OBJECT_TYPE);
String title = visMap.get("title");
visBuilder.append(String.format("%s,%s\n", title, id));
visBuilder.append(String.format(Locale.ROOT, "%s,%s\n", title, id));
});

Check warning on line 79 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L74-L79

Added lines #L74 - L79 were not covered by tests

listener.onResponse((T) visBuilder.toString());

Check warning on line 81 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L81

Added line #L81 was not covered by tests
Expand All @@ -98,7 +99,7 @@ public void onFailure(Exception e) {
String trimIdPrefix(String id) {
id = Optional.ofNullable(id).orElse("");

Check warning on line 100 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L100

Added line #L100 was not covered by tests
if (id.startsWith(SAVED_OBJECT_TYPE)) {
String prefix = String.format("%s:", SAVED_OBJECT_TYPE);
String prefix = String.format(Locale.ROOT, "%s:", SAVED_OBJECT_TYPE);
return id.substring(prefix.length());

Check warning on line 103 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L102-L103

Added lines #L102 - L103 were not covered by tests
}
return id;

Check warning on line 105 in src/main/java/org/opensearch/agent/tools/VisualizationsTool.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/org/opensearch/agent/tools/VisualizationsTool.java#L105

Added line #L105 was not covered by tests
Expand Down

0 comments on commit d77c43d

Please sign in to comment.