Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.16] Revert change to use System Index Registry from core to determine if request matches system indices #4616

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Aug 2, 2024

Description

Preparing this revert PR against 2.16 in case this change needs to be reverted.

During 2.16.0 release prep, integ tests with security were seen failing in Security Analytics Plugin and ISM:

Both of these plugins have SystemIndices registered through the extension point SystemIndexRegistry.getSystemIndexDescriptors, but do not have corresponding entries tracked in security plugins list of system indices. (See #4439 (comment) for registered system indices vs list tracked by security plugin)

Each plugin needs to refactor to ensure that system index interaction is done in a privileged block, but I'm raising this PR in case a revert is needed.

There are 3 possible ways to move forward:

  1. Revert this change and only use the list of system indices tracked by the security plugin here
  2. Temporarily remove SytemIndexRegistration via SystemIndexPlugin.getSystemIndexDescriptors for affected plugins
  3. Wrap system index interaction in affected plugins to ensure that plugins interact with system indices in a privileged block.

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.42%. Comparing base (deef041) to head (4e8fba4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             2.16    #4616      +/-   ##
==========================================
- Coverage   65.42%   65.42%   -0.01%     
==========================================
  Files         316      316              
  Lines       22103    22102       -1     
  Branches     3572     3572              
==========================================
- Hits        14461    14460       -1     
- Misses       5851     5852       +1     
+ Partials     1791     1790       -1     
Files Coverage Δ
...earch/security/privileges/PrivilegesEvaluator.java 71.87% <100.00%> (ø)
...urity/privileges/SecurityIndexAccessEvaluator.java 70.40% <100.00%> (ø)

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants