Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] Update all instances of admin:admin across different repositories #3624

Closed
2 tasks
Tracked by #4115
DarshitChanpura opened this issue Oct 30, 2023 · 45 comments
Closed
2 tasks
Tracked by #4115
Assignees
Labels
campaign triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. v2.12.0 Items targeting 2.12.0

Comments

@DarshitChanpura
Copy link
Member

DarshitChanpura commented Oct 30, 2023

Description

There are many instances of admin:admin credentials usage across different repositories. They will be affected by the change to replace hard-coded admin password with a dynamic value. This issue requests fixing all those instances of admin credentials to address this breaking change.

Acceptance Criteria

  • All hard-coded instances across repos are addressed
  • Ensure that tests, if any, work as expected

Tasks

Search and update the references to admin:admin, password admin and demo install script in following repos, as required:
(to track work done, tag the PR next to the repo name)

(Legend: ❌ - no updates, 🕐 - in progress, ⏳ - Waiting 2.12 release, ✅ - complete)

Status Repo PR Issue Notes
logstash-output-opensearch #233 #234 will be merged post 2.12 release
opensearch-benchmark #430 #474 will be merged post 2.12 release
opensearch-go #449 #459 will be merged post 2.12 release
opensearch-js #669, #707 #699 will be merged post 2.12 release
opensearch-migrations #480 #479 will be merged post 2.12 release
opensearch-py #631 #648 will be merged post 2.12 release
opensearch-rs #234 #236 will be merged post 2.12 release
opensearch-ruby #217 #222 will be merged post 2.12 release
reporting-cli #56 #58 will be merged post 2.12 release
terraform-provider-opensearch #138 #146 will be merged post 2.12 release
Status Repo PR Issue Notes
alerting #1399 #1347
alerting-dashboards-plugin #849 #861
anomaly-detection #1134 #1120
anomaly-detection-dashboards-plugin #662 no action needed
asynchronous-search #521 #515
common-utils #581 #579
cross-cluster-replication #1298 #1310
custom-codecs #92 no action needed
data-prepper #3869 #3978
dashboards-observability #1296 #1371
dashboards-visualizations #308 no action needed
docker-images archived
documentation-website #5887, #6058, #6279 #5946
flow-framework #310 no action needed
geospatial #616 #615
helm-charts #518 #515
index-management #1076 #1064
index-management-dashboards-plugin #954 #957
job-scheduler #553 no action needed
k-NN #1415 #1359
logstash-input-opensearch #55 #56
ml-commons #1899 no action needed
ml-commons-dashboards #292
neural-search #551 #550
notifications #832 no action needed
opensearch-build #4302 #4303
opensearch-cluster-cdk #86
OpenSearch-Dashboards #5736 #5636
opensearch-dashboards-functional-test #981
opensearch-k8s-operator #692 #703 no action neede
opensearch-net #480 #520
opensearch-net-abstractions archived
opensearch-php #172 no action needed
opensearch-py-ml #365 #371
opentelemetry-demo #114 #113
performance-analyzer #613 no action needed
performance-analyzer-rca #526 #527
reporting #938 no action needed
search-processor #214 #216
security #3844
security-analytics #832 #831
security-dashboards-plugin #1696
sql-cli #25 #26
sql-odbc #65 no action needed
@github-actions github-actions bot added the untriaged Require the attention of the repository maintainers and may need to be prioritized label Oct 30, 2023
@stephen-crawford
Copy link
Contributor

[Triage] This is a meta tracking issue for replacing default credential usage in the cluster.

@stephen-crawford stephen-crawford added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Oct 30, 2023
@DarshitChanpura DarshitChanpura added the v2.12.0 Items targeting 2.12.0 label Dec 11, 2023
@derek-ho
Copy link
Collaborator

@derek-ho
Copy link
Collaborator

@derek-ho
Copy link
Collaborator

@derek-ho
Copy link
Collaborator

@dlvenable
Copy link
Member

What version of OpenSearch will have the new password? Data Prepper actually has quite a few occurrences of the password admin. Search for password=admin, password: admin, password: "admin".

@DarshitChanpura
Copy link
Member Author

@dlvenable it will be for version 2.12 and above

@derek-ho
Copy link
Collaborator

@derek-ho
Copy link
Collaborator

@derek-ho
Copy link
Collaborator

@derek-ho
Copy link
Collaborator

@derek-ho
Copy link
Collaborator

@derek-ho
Copy link
Collaborator

@derek-ho
Copy link
Collaborator

@derek-ho
Copy link
Collaborator

@derek-ho
Copy link
Collaborator

Most references in this repo: seem to disable install demo config: https://github.com/opensearch-project/opensearch-benchmark/blob/main/osbenchmark/resources/docker-compose.yml.j2#L18, I don't think we need to do anything for this repo, but maybe we should make an issue and tag maintainers.

@derek-ho
Copy link
Collaborator

derek-ho commented Dec 18, 2023

@derek-ho
Copy link
Collaborator

https://github.com/opensearch-project/opensearch-php/actions/runs/7250326156/job/19750248987 - opensearch-php is running without security it seems like, so no changes necessary

@derek-ho
Copy link
Collaborator

opensearch-project/opensearch-build#4302 - this means that all repos which still need to maintain their own integtest.sh files should be switching to admin:myStrongPassword123! as new default creds

@DarshitChanpura
Copy link
Member Author

[Update: 01/24/'24]

Status Count
Will be merged post release ⌛ 10
In Progress 🕐 8
No updates ❌ 11
Complete ✅ 21

@DarshitChanpura
Copy link
Member Author

[Update: 01/25/'24]

Status Count
Will be merged post release ⌛ 10
In Progress 🕐 11
No updates ❌ 5
Complete ✅ 24

@DarshitChanpura
Copy link
Member Author

DarshitChanpura commented Jan 26, 2024

[Update: 01/26/'24]

Status Count
No updates ❌ 2
In Progress 🕐 7
Will be merged post release ⌛ 9
Complete ✅ 32

@DarshitChanpura
Copy link
Member Author

DarshitChanpura commented Jan 29, 2024

[Update: 01/29/'24]

Status Count
No updates ❌ 2
In Progress 🕐 8
Will be merged post release ⌛ 9
Complete ✅ 32

@DarshitChanpura
Copy link
Member Author

[Update: 01/30/'24]

Status Count
❌ No updates 2
🕐 In Progress 7
⌛ Will be merged post release 9
✅ Complete 33

@DarshitChanpura
Copy link
Member Author

DarshitChanpura commented Jan 31, 2024

[Update: 01/31/'24]

Status Count
❌ No updates 2
🕐 In Progress 6
⌛ Will be merged post release 10
✅ Complete 33

@DarshitChanpura
Copy link
Member Author

[Update: 02/01/'24]

Status Count
❌ No updates 1
🕐 In Progress 4
⌛ Will be merged post release 10
✅ Complete 36

@DarshitChanpura
Copy link
Member Author

DarshitChanpura commented Feb 2, 2024

[Update: 02/02/'24]

Status Count
❌ No updates 1
🕐 In Progress 4
⌛ Will be merged post release 10
✅ Complete 37

@DarshitChanpura
Copy link
Member Author

DarshitChanpura commented Feb 5, 2024

[Update: 02/05/'24]

Status Count
❌ No updates 1
🕐 In Progress 5
⌛ Will be merged post release 10
✅ Complete 37

@DarshitChanpura
Copy link
Member Author

DarshitChanpura commented Feb 6, 2024

[Update: 02/06/'24]

Status Count
❌ No updates 0
🕐 In Progress 2
⌛ Will be merged post release 9
✅ Complete 42

@DarshitChanpura
Copy link
Member Author

[Update: 02/07/'24]

Status Count
❌ No updates 0
🕐 In Progress 2
⌛ Will be merged post release 9
✅ Complete 42

@DarshitChanpura
Copy link
Member Author

DarshitChanpura commented Feb 8, 2024

[Update: 02/08/'24]

Status Count
❌ No updates 0
🕐 In Progress 0
⌛ Will be merged post release 11
✅ Complete 42

@DarshitChanpura
Copy link
Member Author

Next update will be post 2.12 release. This task is no longer a blocker for 2.12

@DarshitChanpura
Copy link
Member Author

[Update: 02/22/'24]

Status Count
❌ No updates 0
🕐 In Progress 0
⏳ Will be merged post release 9
✅ Complete 44

This is the last update on this issue. The maintainers of PRs with ⏳ status have been nudged to bring this across the finish line. Closing this as the feature has been delivered in 2.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
campaign triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. v2.12.0 Items targeting 2.12.0
Projects
None yet
Development

No branches or pull requests

7 participants