Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Set up a Util class for OBO Authenticator for key checks and endpoints checks #3238

Closed
Tracked by #2573
RyanL1997 opened this issue Aug 24, 2023 · 3 comments · Fixed by #3419
Closed
Tracked by #2573
Assignees
Labels
enhancement New feature or request

Comments

@RyanL1997
Copy link
Collaborator

RyanL1997 commented Aug 24, 2023

Description

Transferring some of the discussion from here, it is reasonable to setup a public field in codebase to holding some of the common logic for OBO authentication, such as the configuration checks.

Related issue/PR

Potential solutions

Potential place 1: ~/security/src/test/java/org/opensearch/security/authtoken

  • reason: it is related to the OnBehalfOf feature, so that we can setup an util class in here.

**Potential place 2: ~/security/src/main/java/org/opensearch/security/util

  • reason: Just like its name it is the util directory. (Recommended)

Exit Criteria

Set up the ultil class to place the reusable logic for checking endpoint calls, checking keys.

@RyanL1997 RyanL1997 added enhancement New feature or request untriaged Require the attention of the repository maintainers and may need to be prioritized labels Aug 24, 2023
@peternied peternied removed the untriaged Require the attention of the repository maintainers and may need to be prioritized label Aug 28, 2023
@peternied
Copy link
Member

[Triage] It isn't clear what the expected outcome since the source isn't as obvious. Maybe a pull request would answer these questions?

@stephen-crawford
Copy link
Contributor

[Triage] Hi @RyanL1997 following up on this for additional details. Thank you.

@peternied
Copy link
Member

@peternied Can you do a quick review of this work

@RyanL1997 RyanL1997 self-assigned this Sep 27, 2023
@RyanL1997 RyanL1997 changed the title [Enhancement] Set up a Util class as for OBO Authentication [Enhancement] Set up a Util class for OBO Authenticator for Key checks and endpoints Oct 2, 2023
@RyanL1997 RyanL1997 changed the title [Enhancement] Set up a Util class for OBO Authenticator for Key checks and endpoints [Enhancement] Set up a Util class for OBO Authenticator for key checks and endpoints checks Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants