Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Despite Read Only Dashboard Role a user can rearrange visualizations on a dashboard #917

Closed
Tracked by #2701
inf17101 opened this issue Mar 7, 2022 · 4 comments
Closed
Tracked by #2701
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest Global event that encourages people to contribute to open-source. help wanted Extra attention is needed, need help from community triaged

Comments

@inf17101
Copy link

inf17101 commented Mar 7, 2022

Describe the bug
If you create a Read Only User according to the documentation (https://opensearch.org/docs/latest/security-plugin/access-control/users-roles/#set-up-a-read-only-user-in-opensearch-dashboards) a user is able to rearrange visualizations on a dashboard and can save the dashboard.

I have used the predefined kibana roles of the roles.yml instead of the renamed roles according to the documentation:
kibana_user
kibana_read_only
custom_role according to documentation plus restriction to specific tenant

To Reproduce
Steps to reproduce the behavior:

  1. Create a tenant
  2. Create a read only user according to documentation
  3. restrict the custom role for the read only user to the tenant
  4. Log in and access a dashboard
  5. Rearrange some visualizations
  6. Click on save

Expected behavior
It would be very nice to have "really" read only role that looks like the following:

  1. The user cannot see any edit, create or change buttons.
  2. The user cannot rearrange visualizations on dashboards
  3. The user can only use a certain time range -> document level security filter causes errors if data outside the time range is inside the cluster
  4. In addition: Ability to switch on and off reporting button (if a user should be able to create a report on demand then a reporting button should be shown, if the user should not be able to create reports the button should not be visible to the user.

OpenSearch Version
1.2.2

Dashboards Version
1.2.0

Plugins

Please list all plugins currently enabled.
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]

If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • Opensearch and Opensearch Dashboards are running on Linux Ubuntu Server 20.04
  • Win10 / Chrome Version 98.0.4758.102

Additional context

It would be nice to have more granular access control with a more adaptive Web UI according to the permissions of RBAC.
You have to imagine that if you want to use Opensearch in production than it is very hard to discuss with "Read Only" Users why they can rearrange the visualizations or can see any edit / create or reporting buttons if they are not allowed to do that.

From a company's point of view it would be very nice to see a full documentation about the process and steps to create a secure "read only" user to make sure , no unneccessary dashboard buttons are available for the user, the user cannot change anything and the user cannot see data from other spaces / indices they are not owning.

@inf17101 inf17101 added bug Something isn't working untriaged labels Mar 7, 2022
@kavilla
Copy link
Member

kavilla commented Mar 7, 2022

Hello @inf17101, thanks for opening! Re-routing to the security plugin repo.

@kavilla kavilla transferred this issue from opensearch-project/OpenSearch-Dashboards Mar 7, 2022
@peternied peternied added help wanted Extra attention is needed, need help from community and removed untriaged labels Apr 1, 2022
@peternied
Copy link
Member

[Triage] This is a good issue for a first time contribution

@peternied peternied added the good first issue Good for newcomers label Apr 1, 2022
@davidlago davidlago added triaged hacktoberfest Global event that encourages people to contribute to open-source. labels Oct 10, 2022
@nibix
Copy link

nibix commented May 19, 2023

See opensearch-project/security#2701 (comment) for an analysis of the kibana_read_only role feature.

@davidlago
Copy link

Work to re-think the read only mode is happening in that issue that @nibix points at (opensearch-project/security#2701), closing this one in its favor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest Global event that encourages people to contribute to open-source. help wanted Extra attention is needed, need help from community triaged
Projects
None yet
Development

No branches or pull requests

5 participants