Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] adds index_uuid as a tag in node stats all shard metrics #680

Merged
merged 6 commits into from
Jul 23, 2024

Conversation

atharvasharma61
Copy link
Contributor

@atharvasharma61 atharvasharma61 commented Jul 11, 2024

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you are proposing

  1. Adds index_uuid as a dimension for metrics emitted by RTF collector NodeStatsAllShardsMetricsCollector

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context

  • Test results for adding index_uuid:
metric: ImmutableMetricData{resource=Resource{schemaUrl=null, attributes={service.name="OpenSearch"}}, instrumentationScopeInfo=InstrumentationScopeInfo{name=org.opensearch.telemetry, version=null, schemaUrl=null, attributes={}}, name=cache_field_data_eviction, description=CacheFieldDataEviction Metrics, unit=count, type=DOUBLE_SUM, data=ImmutableSumData{points=[ImmutableDoublePointData{startEpochNanos=1721648656776899000, epochNanos=1721649020465768000, attributes={index_name="your-index", index_uuid="TxGu9noCSQKt8OE8ioR1-A", shard_id="0"}, value=0.0, exemplars=[]}], monotonic=true, aggregationTemporality=CUMULATIVE}}

Check List

  • Backport Labels added.
  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@atharvasharma61
Copy link
Contributor Author

Testing output:

attributes={index_name="your-index", index_uuid="Yygq9wWbTHu0XvcWIhrXcA", shard_id="0"}

@atharvasharma61 atharvasharma61 changed the title [Feature] Adds index_uuid as a dimension for node stats col [Feature] updates gauge usage and adds index_uuid as a tag Jul 22, 2024
Signed-off-by: Atharva Sharma <[email protected]>
Signed-off-by: Atharva Sharma <[email protected]>
Signed-off-by: Atharva Sharma <[email protected]>
@atharvasharma61 atharvasharma61 changed the title [Feature] updates gauge usage and adds index_uuid as a tag [Feature] adds index_uuid as a tag in node stats all shard metrics Jul 23, 2024
@Gaganjuneja Gaganjuneja merged commit 948b54a into opensearch-project:main Jul 23, 2024
5 of 7 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 23, 2024
)

* Adds index_uuid as a dimension for node stats col

Signed-off-by: Atharva Sharma <[email protected]>

* updates gauge usage and added index_uuid as tag

Signed-off-by: Atharva Sharma <[email protected]>

* removed incomplete collector

Signed-off-by: Atharva Sharma <[email protected]>

* fixed UTs after gauge changes

Signed-off-by: Atharva Sharma <[email protected]>

* addressed comments

Signed-off-by: Atharva Sharma <[email protected]>

* reverted gauge related changes

Signed-off-by: Atharva Sharma <[email protected]>

---------

Signed-off-by: Atharva Sharma <[email protected]>
(cherry picked from commit 948b54a)
Gaganjuneja pushed a commit that referenced this pull request Jul 23, 2024
) (#689)

* Adds index_uuid as a dimension for node stats col

Signed-off-by: Atharva Sharma <[email protected]>

* updates gauge usage and added index_uuid as tag

Signed-off-by: Atharva Sharma <[email protected]>

* removed incomplete collector

Signed-off-by: Atharva Sharma <[email protected]>

* fixed UTs after gauge changes

Signed-off-by: Atharva Sharma <[email protected]>

* addressed comments

Signed-off-by: Atharva Sharma <[email protected]>

* reverted gauge related changes

Signed-off-by: Atharva Sharma <[email protected]>

---------

Signed-off-by: Atharva Sharma <[email protected]>
(cherry picked from commit 948b54a)

Co-authored-by: Atharva Sharma <[email protected]>
psychbot pushed a commit that referenced this pull request Jul 26, 2024
* [Feature] adds index_uuid as a tag in node stats all shard metrics (#680) (#689)

* Adds index_uuid as a dimension for node stats col

Signed-off-by: Atharva Sharma <[email protected]>

* updates gauge usage and added index_uuid as tag

Signed-off-by: Atharva Sharma <[email protected]>

* removed incomplete collector

Signed-off-by: Atharva Sharma <[email protected]>

* fixed UTs after gauge changes

Signed-off-by: Atharva Sharma <[email protected]>

* addressed comments

Signed-off-by: Atharva Sharma <[email protected]>

* reverted gauge related changes

Signed-off-by: Atharva Sharma <[email protected]>

---------

Signed-off-by: Atharva Sharma <[email protected]>
(cherry picked from commit 948b54a)

Co-authored-by: Atharva Sharma <[email protected]>

* Adds the listener for resource utilization metrics (#687) (#688)

* Adds the listener for resource utilization metrics

Signed-off-by: Gagan Juneja <[email protected]>
Co-authored-by: Gagan Juneja <[email protected]>
(cherry picked from commit c95feb6)

Co-authored-by: Gagan Juneja <[email protected]>

---------

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Atharva Sharma <[email protected]>
peterzhuamazon pushed a commit that referenced this pull request Jul 29, 2024
* [Feature] adds index_uuid as a tag in node stats all shard metrics (#680) (#689)

* Adds index_uuid as a dimension for node stats col

Signed-off-by: Atharva Sharma <[email protected]>

* updates gauge usage and added index_uuid as tag

Signed-off-by: Atharva Sharma <[email protected]>

* removed incomplete collector

Signed-off-by: Atharva Sharma <[email protected]>

* fixed UTs after gauge changes

Signed-off-by: Atharva Sharma <[email protected]>

* addressed comments

Signed-off-by: Atharva Sharma <[email protected]>

* reverted gauge related changes

Signed-off-by: Atharva Sharma <[email protected]>

---------

Signed-off-by: Atharva Sharma <[email protected]>
(cherry picked from commit 948b54a)

Co-authored-by: Atharva Sharma <[email protected]>

* Adds the listener for resource utilization metrics (#687) (#688)

* Adds the listener for resource utilization metrics

Signed-off-by: Gagan Juneja <[email protected]>
Co-authored-by: Gagan Juneja <[email protected]>
(cherry picked from commit c95feb6)

Co-authored-by: Gagan Juneja <[email protected]>

---------

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Atharva Sharma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants